This repository has been archived by the owner on Feb 4, 2025. It is now read-only.
[Global Styles] Implements Global Styles API Call #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis
force-pushed
the
add/3163-GSS
branch
3 times, most recently
from
4a0fdab to
bdfe7cf
Compare
antonis
changed the title
This was referenced May 5, 2021
Merged
antonis
changed the title
3 tasks
antonis
force-pushed
the
add/3163-GSS
branch
2 times, most recently
from
003819a to
f3cb095
Compare
added 8 commits
June 17, 2021 09:10
…d to the editor" This reverts commit b6ea06200213c54826869db9f994e2769813c0ff.
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
added 3 commits
June 23, 2021 08:51
# Conflicts: # fluxc/src/main/java/org/wordpress/android/fluxc/persistence/WellSqlConfig.kt
chipsnyder
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
Changes look good Nice work @antonis 👍
I only had time to give it a smoke test but I'll do a more thorough test before we fully turn the feature on.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/gutenberg-mobile#3163
gutenbergPR: WordPress/gutenberg#30544gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3459WordPress-AndroidPR: wordpress-mobile/WordPress-Android#14597Description
This PR adds support for the new Global styles API endpoint.
To Test
Use the app from the Android PR, turn on the
GlobalStyleSupportFeatureConfig(Me > App Settings > Test feature configuration) and follow the test instructions on:Optionally: