Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Global Styles] Adds Global Styles API Call and passes the value to the editor via a new prop #14597

Merged
merged 10 commits into from
Jun 29, 2021
Merged

[Global Styles] Adds Global Styles API Call and passes the value to the editor via a new prop #14597

merged 10 commits into from
Jun 29, 2021

Conversation

antonis
Copy link
Contributor

@antonis antonis commented May 5, 2021 •
edited
Loading

Fixes: wordpress-mobile/gutenberg-mobile#3163

gutenberg PR: WordPress/gutenberg#30544
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#3459
WordPress-FluxC-Android PR: wordpress-mobile/WordPress-FluxC-Android#1940

Description

This PR adds a feature flag for consuming the new the new Global styles API endpoint (wordpress-mobile/WordPress-FluxC-Android#1940)

To Test

Use the app from this PR, turn on the GlobalStyleSupportFeatureConfig (Me > App Settings > Test feature configuration) and follow the test instructions on:

Optionally:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 5, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

This was referenced May 5, 2021
Merged
Merged
Merged
@antonis antonis changed the title [Global Styles] Adds Global Styles API Call and passes the content to the editor [Global Styles] Adds Global Styles API Call and passes the value to the editor via a new prop May 5, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 5, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading the APKs:

@antonis antonis self-assigned this May 5, 2021
@antonis antonis force-pushed the issue/3163-GSS branch 2 times, most recently from c3819dc to 70519b9 Compare May 26, 2021 13:58
@antonis
Copy link
Contributor Author

antonis commented May 26, 2021

Hey @geriux 👋
I temporarily disabled the site version check to align with iOS and added a feature flag under App Settings > Test Feature configuration.
Let me know if the new APK works for you 🙇

@geriux
Copy link
Contributor

geriux commented May 27, 2021

Hey @geriux 👋
I temporarily disabled the site version check to align with iOS and added a feature flag under App Settings > Test Feature configuration.
Let me know if the new APK works for you 🙇

Thank you so much @antonis I'll give it a try! 🚀

@antonis antonis requested review from chipsnyder and geriux May 27, 2021 12:11
@geriux geriux mentioned this pull request May 28, 2021
Merged
7 tasks
Antonis Lilis and others added 6 commits June 17, 2021 09:35
@geriux geriux mentioned this pull request Jun 24, 2021
Merged
7 tasks
@antonis
Copy link
Contributor Author

antonis commented Jun 28, 2021

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Since the new functionality is behind a feature flag that is off by default I'm not sure if we want to add release notes at this point. Wdyt @geriux?

@antonis antonis marked this pull request as ready for review June 28, 2021 13:55
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@geriux
Copy link
Contributor

geriux commented Jun 28, 2021

Since the new functionality is behind a feature flag that is off by default I'm not sure if we want to add release notes at this point. Wdyt @geriux?

Yeah, I think we should wait until it's released to avoid confusion. 👍

chipsnyder
chipsnyder approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good Nice work @antonis 👍

I only had time to give it a smoke test but I'll do a more thorough test before we fully turn the feature on.

Merge branch 'develop' into issue/3163-GSS
ce83bdd 
# Conflicts:
#	build.gradle
This was referenced Jun 29, 2021
Merged
Merged
@antonis antonis merged commit f3eb17c into develop Jun 29, 2021
@antonis antonis deleted the issue/3163-GSS branch June 29, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipsnyder chipsnyder chipsnyder approved these changes

@geriux geriux Awaiting requested review from geriux

Assignees

@antonis antonis

Labels
[Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonis @geriux @chipsnyder