Add editor onboarding capability #14558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
Gutenberg
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
This was referenced Apr 29, 2021
This always equates to false. The percentage needs to be increased. It also needs to only be enabled for fresh installs.
Track if the Gutenberg editor has been launched before to avoid onboarding the user multiple times.
Allow enabling editor onboarding in development and testing environments, rather than adjusting the percentage of users included. This build config may be removed once development of onboarding features is complete.
dcalhoun
force-pushed
the
add/editor-onboarding-capability
branch
from
3eee54d to
080dd58
Compare
|
You can test the changes on this Pull Request by downloading the APK here. |
dcalhoun
removed
Part of a WIP Feature
mchowning
reviewed
May 7, 2021
jhnstn
reviewed
May 7, 2021
There is no value in the custom development flag as we can rely upon the existing `BuildConfig.DEBUG` flag for development and testing purposes.
mchowning
approved these changes
May 12, 2021
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
Outdated
Show resolved
Hide resolved
Follow best practices to avoid allocating the same `int` multiple times via a static variable.
…id into add/editor-onboarding-capability
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add editor onboarding capability to control visibility of the feature.
To test: Follow steps outlined in wordpress-mobile/gutenberg-mobile#3437.
Regression Notes
Modifications to build configuration could cause build failures. Modifications within Gutenberg editor lifecycle could cause editor to crash.
Ensured builds succeeded locally. Verified editor launched without error.
Includes no user-facing or critical routines to test.
PR submission checklist:
RELEASE-NOTES.txtif necessary.