Add editor onboarding capability #31349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
Mobile App - i.e. Android or iOS
This was referenced Apr 29, 2021
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
dcalhoun
force-pushed
the
add/editor-onboarding-capability
branch
2 times, most recently
from
99149dd to
40f4b03
Compare
jhnstn
approved these changes
May 11, 2021
There was a problem hiding this comment.
I ran through the test steps in the Gutenberg mobile PR and got the expected results.
The changes look straight forward to me so I'll approve the PRs.
We might want to get someone with more native bridge experience to give this a final check.
@mchowning offered to take a look, perhaps he can take a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add editor onboarding capability to control visibility of the feature.
How has this been tested?
Follow steps outlined in wordpress-mobile/gutenberg-mobile#3437.
Screenshots
n/a
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).