-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shipping label new experience navigation #13431
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix is working just fine, thanks for taking care of it, @atorresveiga!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13431 +/- ##
============================================
- Coverage 41.38% 41.38% -0.01%
+ Complexity 6577 6576 -1
============================================
Files 1329 1329
Lines 77814 77816 +2
Branches 10711 10711
============================================
- Hits 32202 32201 -1
- Misses 42755 42757 +2
- Partials 2857 2858 +1 ☔ View full report in Codecov by Sentry. |
Description
This PR fixes a small regression introduced in this PR when improving the navigation experience by taking into account the bottom sheets.
Testing information
TC1
TC2
The tests that have been performed
Images/gif
Screen_recording_20250131_130426.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: