Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shipping label new experience navigation #13431

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

atorresveiga
Copy link
Contributor

@atorresveiga atorresveiga commented Jan 31, 2025

Description

This PR fixes a small regression introduced in this PR when improving the navigation experience by taking into account the bottom sheets.

Testing information

TC1

  1. Open the orders tab
  2. Tap on an order eligible for shipping label creation
  3. Expand the shipment details section
  4. Expand on the origin address selection (3 dots)
  5. Navigate back gesture
  6. Check that the origin address selection is dismissed
  7. Navigate back gesture again
  8. Check that the shipment details section is collapsed

TC2

  1. Open the orders tab
  2. Tap on an order eligible for shipping label creation
  3. Tap on the navigate back arrow (<-) and check that the app navigates to the previous screen

The tests that have been performed

  • Checking the navigation works as expected, navigating back with the back button (<-) or the back gestures

Images/gif

Screen_recording_20250131_130426.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@atorresveiga atorresveiga added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Jan 31, 2025
@atorresveiga atorresveiga added this to the 21.7 milestone Jan 31, 2025
@atorresveiga atorresveiga requested a review from ThomazFB January 31, 2025 16:07
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 31, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitf34b4c9
Direct Downloadwoocommerce-wear-prototype-build-pr13431-f34b4c9.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 31, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitf34b4c9
Direct Downloadwoocommerce-prototype-build-pr13431-f34b4c9.apk

@ThomazFB ThomazFB self-assigned this Jan 31, 2025
Copy link
Contributor

@ThomazFB ThomazFB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is working just fine, thanks for taking care of it, @atorresveiga!

@atorresveiga atorresveiga merged commit 6ef97c4 into trunk Jan 31, 2025
15 checks passed
@atorresveiga atorresveiga deleted the fix/shipping-label-navigation branch January 31, 2025 21:56
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.38%. Comparing base (123033e) to head (f34b4c9).
Report is 5 commits behind head on trunk.

Files with missing lines Patch % Lines
...hippinglabels/WooShippingLabelCreationViewModel.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13431      +/-   ##
============================================
- Coverage     41.38%   41.38%   -0.01%     
+ Complexity     6577     6576       -1     
============================================
  Files          1329     1329              
  Lines         77814    77816       +2     
  Branches      10711    10711              
============================================
- Hits          32202    32201       -1     
- Misses        42755    42757       +2     
- Partials       2857     2858       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants