-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve navigation with bottom sheets #13291
Merged
atorresveiga
merged 5 commits into
trunk
from
issue/12439-improve-navigation-with-bottom-sheets
Jan 14, 2025
Merged
Improve navigation with bottom sheets #13291
atorresveiga
merged 5 commits into
trunk
from
issue/12439-improve-navigation-with-bottom-sheets
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…sue/12439-improve-navigation-with-bottom-sheets
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #13291 +/- ##
=========================================
Coverage 41.09% 41.10%
- Complexity 6418 6421 +3
=========================================
Files 1321 1321
Lines 77172 77179 +7
Branches 10641 10643 +2
=========================================
+ Hits 31715 31724 +9
+ Misses 42648 42646 -2
Partials 2809 2809 ☔ View full report in Codecov by Sentry. |
Base automatically changed from
issue/12439-save-bottom-sheets-state-viewmodel
to
trunk
January 14, 2025 00:40
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature: shipping labels
Related to creating, ordering, or printing shipping labels.
type: enhancement
A request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #12439
Description
This PR improves the shipping label navigation by using the navigation back to close the opened bottom sheets before navigating to the previous screen.
Testing information
The tests that have been performed
Checking the UI works as expected
Images/gif
Screen_recording_20250112_160139.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: