Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve navigation with bottom sheets #13291

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

atorresveiga
Copy link
Contributor

@atorresveiga atorresveiga commented Jan 12, 2025

Part of: #12439

Description

This PR improves the shipping label navigation by using the navigation back to close the opened bottom sheets before navigating to the previous screen.

Testing information

  1. Open the orders tab
  2. Tap on an order eligible for shipping label creation
  3. Expand the shipment details section
  4. Expand on the origin address selection (3 dots)
  5. Navigate back gesture
  6. Check that the origin address selection is dismissed
  7. Navigate back gesture again
  8. Check that the shipment details section is collapsed

The tests that have been performed

Checking the UI works as expected

Images/gif

Screen_recording_20250112_160139.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@atorresveiga atorresveiga added type: enhancement A request for an enhancement. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Jan 12, 2025
@atorresveiga atorresveiga added this to the 21.5 milestone Jan 12, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 12, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit3ad85bb
Direct Downloadwoocommerce-wear-prototype-build-pr13291-3ad85bb.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 12, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit3ad85bb
Direct Downloadwoocommerce-prototype-build-pr13291-3ad85bb.apk

Alejo added 2 commits January 13, 2025 11:00
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.10%. Comparing base (68bcda6) to head (3ad85bb).
Report is 6 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #13291   +/-   ##
=========================================
  Coverage     41.09%   41.10%           
- Complexity     6418     6421    +3     
=========================================
  Files          1321     1321           
  Lines         77172    77179    +7     
  Branches      10641    10643    +2     
=========================================
+ Hits          31715    31724    +9     
+ Misses        42648    42646    -2     
  Partials       2809     2809           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from issue/12439-save-bottom-sheets-state-viewmodel to trunk January 14, 2025 00:40
@atorresveiga atorresveiga merged commit 7479676 into trunk Jan 14, 2025
16 of 19 checks passed
@atorresveiga atorresveiga deleted the issue/12439-improve-navigation-with-bottom-sheets branch January 14, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants