Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Fixes React Live by pinning buble version #608

Merged
merged 2 commits into from
Oct 19, 2018

Conversation

belcherj
Copy link
Contributor

See bublejs/buble#159

This (sort of) pins buble to the last good version, 0.19.4. react-live uses a ^ version, which picked up the broken release during the renovate update sweep.

PR in to fix react-live: FormidableLabs/react-live#105

Fix and description stolen from: Automattic/wp-calypso#27966

@belcherj belcherj self-assigned this Oct 19, 2018
@belcherj belcherj requested a review from ryelle October 19, 2018 18:21
@belcherj
Copy link
Contributor Author

Sorry ya'll looks like prettier decided to format the package.json.

Only added one line: "buble": "0.19.4",

@belcherj belcherj requested a review from a team October 19, 2018 18:22
Copy link
Member

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you undo the prettier changes, so that you're only changing the one line? I'm guessing it was your editor that formatted it, since the precommit hook only formats files in client.

Otherwise, this is a good change & it's working for me.

@belcherj belcherj merged commit 808823c into master Oct 19, 2018
@belcherj belcherj deleted the fix/react-live-pin-buble-version branch October 19, 2018 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants