Pin buble to 0.19.4. The current version is broken. #27966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blowery
added
[Status] Needs Review
This is an automated check which relies on Generated by 🚫 dangerJS |
|
Should an issue be created to remove this dependency once react-live is updated to use a version that isn't broken? |
belcherj
approved these changes
Oct 19, 2018
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See bublejs/buble#159
This (sort of) pins buble to the last good version, 0.19.4.
react-liveuses a^version, which picked up the broken release during an unrelated (#27864) shrinkwrap update.Testing Instructions:
https://hash-e467a07d80a6378da89c7c8caced451b67e43b4e.calypso.live/devdocs/design should work. :)