Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Refactor modal types and introduce side sheet #235

Merged
merged 8 commits into from
Jun 29, 2024

Conversation

ulusoyca
Copy link
Collaborator

@ulusoyca ulusoyca commented Jun 18, 2024

Description

This PR replaces the WoltModalType enum with the WoltModalType abstract class, designed to standardize the behavior and appearance of various modal types across the application. It also includes the implementation of specific modal types that extend WoltModalType, such as WoltDialogType, WoltBottomSheetType, and WoltSideSheetType. This implementation ensures consistency in our modals' design and enables modal type customization.

Note

This PR updates the existing specs of dialog and bottom sheets according to Wolt's design system, and introduces side sheet specs.

Here is the specs:
alc_design_break_points

Screenshots with safe area

Verical Bottomsheet Horizontal Bottomsheet
image image
image image
Verical Dialog Horizontal Dialog
image image
image image
Vertical Side Sheet Horizontal Side Sheet
image image
image image
LTR Side Sheet LTR SIde Sheet
image image
image image
Bottomsheet Responsive
bottom_resp.mov
Dialog Responsive
dialog_resp.mov
Side sheet responsive
sidesheet_resp.mov

Related Issues

Issues Related

Issues related to this feature is labeled with Custom Modal Type

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@ulusoyca ulusoyca requested a review from TahaTesser June 18, 2024 21:47
Copy link

github-actions bot commented Jun 18, 2024

@ulusoyca ulusoyca force-pushed the introduce-side-sheet branch from 4617393 to 30950fe Compare June 19, 2024 19:14
Copy link
Collaborator

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mind blowing. Excellent work1

Apologies for delayed review as I've been moving to another city this.

lib/src/modal_type/wolt_dialog_type.dart Outdated Show resolved Hide resolved
lib/src/modal_type/wolt_dialog_type.dart Outdated Show resolved Hide resolved
lib/src/theme/wolt_modal_sheet_default_theme_data.dart Outdated Show resolved Hide resolved
lib/src/wolt_modal_sheet_route.dart Outdated Show resolved Hide resolved
@ulusoyca ulusoyca force-pushed the introduce-side-sheet branch 2 times, most recently from a409b91 to 9e00641 Compare June 29, 2024 15:19
@ulusoyca ulusoyca force-pushed the introduce-side-sheet branch from 9e00641 to 716933c Compare June 29, 2024 15:19
@ulusoyca ulusoyca merged commit 3845796 into main Jun 29, 2024
4 of 5 checks passed
@ulusoyca ulusoyca deleted the introduce-side-sheet branch June 29, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants