-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Refactor modal types and introduce side sheet #235
Conversation
Visit the preview URL for this PR (updated for commit 716933c):
(expires Sat, 06 Jul 2024 15:23:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 00f7f56c8a4ce5693de819a908406c0fc6411226 |
lib/src/content/components/main_content/wolt_modal_sheet_main_content.dart
Outdated
Show resolved
Hide resolved
4617393
to
30950fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mind blowing. Excellent work1
Apologies for delayed review as I've been moving to another city this.
a409b91
to
9e00641
Compare
9e00641
to
716933c
Compare
Description
This PR replaces the
WoltModalType
enum with theWoltModalType
abstract class, designed to standardize the behavior and appearance of various modal types across the application. It also includes the implementation of specific modal types that extend WoltModalType, such as WoltDialogType, WoltBottomSheetType, and WoltSideSheetType. This implementation ensures consistency in our modals' design and enables modal type customization.Note
This PR updates the existing specs of dialog and bottom sheets according to Wolt's design system, and introduces side sheet specs.
Here is the specs:
Screenshots with safe area
bottom_resp.mov
dialog_resp.mov
sidesheet_resp.mov
Related Issues
Issues Related
Issues related to this feature is labeled with Custom Modal Type
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process.
///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?