Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add side sheet modal type #25

Closed
ulusoyca opened this issue Jul 28, 2023 · 4 comments
Closed

Add side sheet modal type #25

ulusoyca opened this issue Jul 28, 2023 · 4 comments
Assignees
@ulusoyca
Labels
Custom Modal Type requires-design

Comments

@ulusoyca
Copy link
Collaborator

ulusoyca commented Jul 28, 2023 •
edited
Loading

Currently we are returning bottom sheet or dialog:

enum WoltModalType {
  bottomSheet,
  dialog;
}

It is possible to add side sheet option: https://m3.material.io/components/side-sheets/overview
@ulusoyca ulusoyca self-assigned this Jul 28, 2023
@ulusoyca ulusoyca added enhancement New feature or request requires-design labels Jul 28, 2023
@ulusoyca ulusoyca moved this to 🎨 Design Review in WoltModalSheet Backlog Jul 28, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 28, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2023
@github-project-automation github-project-automation bot moved this from 🎨 Needs Design Review to ✅ Done in WoltModalSheet Backlog Sep 5, 2023
@MahanRahmati
Copy link

@ulusoyca Hello there. Is this planned?

@ulusoyca
Copy link
Collaborator Author

ulusoyca commented Jun 3, 2024

@ulusoyca Hello there. Is this planned?

Yes, next release 4th July will support side sheet. Here is the WIP branch. Currently waiting the design specs for the side sheet from the designer team.

@ulusoyca ulusoyca reopened this Jun 3, 2024
@ulusoyca ulusoyca added Custom Modal Type and removed enhancement New feature or request Stale labels Jun 4, 2024
This was referenced Jun 9, 2024
Closed
Closed
@ulusoyca ulusoyca mentioned this issue Jun 18, 2024
Merged
8 tasks
@ulusoyca
Copy link
Collaborator Author

ulusoyca commented Jul 2, 2024

Fixed in #241

@ulusoyca ulusoyca closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulusoyca ulusoyca

Labels
Custom Modal Type requires-design
Projects
WoltModalSheet Backlog
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ulusoyca @MahanRahmati