Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run benchmarks on comment #4960

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Run benchmarks on comment #4960

merged 2 commits into from
Oct 3, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Oct 3, 2022

Changes

  • Adds a new special comment for running benchmarks on a PR.

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: f6d3d0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Oct 3, 2022
@matthewp
Copy link
Contributor Author

matthewp commented Oct 3, 2022

!bench

@matthewp
Copy link
Contributor Author

matthewp commented Oct 3, 2022

From the last time we added an action like this: #4483.

It seems we can't test this in this PR. will test once merged.

@matthewp matthewp marked this pull request as ready for review October 3, 2022 19:38
@matthewp matthewp merged commit f93625e into main Oct 3, 2022
@matthewp matthewp deleted the run-bench branch October 3, 2022 20:11
natemoo-re
natemoo-re reviewed Oct 3, 2022
View reviewed changes
.github/workflows/benchmark.yml
Comment on lines +37 to +41
- name: Install dependencies
run: pnpm install

- name: Run benchmark
id: benchmark-pr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to build before running the benchmark?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
🚨 action Modifies GitHub Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewp @natemoo-re