Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new preview release action #4483

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Add a new preview release action #4483

merged 5 commits into from
Sep 12, 2022

Conversation

FredKSchott
Copy link
Member

Changes

Testing

  • CI actions are impossible to test in GH until they've been merged to the main branch, so some debugging post-merge may be expected

Docs

  • N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2022

⚠️ No Changeset found

Latest commit: 9ea61fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Aug 25, 2022
@matthewp
Copy link
Contributor

@FredKSchott is this one ready to go (be reviewed)? If not can you switch it to draft? Thanks.

@FredKSchott FredKSchott marked this pull request as draft September 1, 2022 13:21
@FredKSchott
Copy link
Member Author

Switched to draft! I think it's basically ready for review but its been off my radar, I'll post in PTAL when its ready for review.

@FredKSchott FredKSchott marked this pull request as ready for review September 12, 2022 19:45
@FredKSchott
Copy link
Member Author

FYI because I want to test this as much as possible before it can actually release packages / talk to npm, here's the process for merging this that I'd like to follow:

  • Get approval on this PR as-written
  • I'll comment out the actual release step, and then merge. This becomes a dry-run that we can debug in CI
  • If the dry-run goes well, Tony will add back the commented-out release step of the CI job in a final PR

Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! If you want to comment out the publish step we can test it with a dry-run for @astrojs/image@next

@FredKSchott FredKSchott merged commit c58d962 into main Sep 12, 2022
@FredKSchott FredKSchott deleted the new-ci-preview-action branch September 12, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 action Modifies GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants