Serialisation of client capabilities (take 2) #3909
Conversation
zebot
added
the
ok-to-test
pcapriotti
force-pushed
the
pcapriotti/capabilities
branch
from
36c12a7 to
997b33a
Compare
pcapriotti
force-pushed
the
pcapriotti/capabilities
branch
from
997b33a to
997dcc2
Compare
| @@ -373,17 +379,17 @@ instance Swagger.ToSchema UserClientsFull where | |||
|
|
|||
| instance ToJSON UserClientsFull where | |||
| toJSON = | |||
| toJSON . Map.foldrWithKey' fn Map.empty . userClientsFull | |||
| toJSON . Map.foldrWithKey' f Map.empty . userClientsFull | |||
There was a problem hiding this comment.
it's not a big deal, ignore this if you like. but in general (a) i don't like single-character identifiers, even locally; (b) i want us all to avoid edit wars.
There was a problem hiding this comment.
You don't like single-character identifiers, but two-character ones are ok? That's a bit of a strange stance. But sure, I'll revert it.
Co-authored-by: Matthias Fischmann <[email protected]>
mdimjasevic
force-pushed
the
pcapriotti/capabilities
branch
from
ff26b74 to
1ce2ed8
Compare
|
@pcapriotti , in an attempt to get the PR through the CI, I took the liberty to rebase the PR on top of |
|
As far as I can tell, now we're getting actual test failures: https://concourse.ops.zinfra.io/builds/49403780 |
Thanks for rebasing. Yes, that's right. It should be fixed now. |
* Use Multiverb in add-client endpoint * Add versioned Client schema * Add v5 version of more client endpoints * Version client list * Update golden files * Add CHANGELOG entry * Use old format in client-add event * Add note about migration plan Co-authored-by: Matthias Fischmann <[email protected]> * Revert cosmetic change * Fix assertion in brig integration test --------- Co-authored-by: Matthias Fischmann <[email protected]>
echoes-hq
bot
added
the
echoes: unplanned
Fix an oddity in the serialisation of capabilities in the Client structure.
This PR replaces #3873 and simplifies the implementation. No new types are added, and the difference in serialisation is obtained using the Versioned wrapper, which we are already using for versioned changes in serialisation.
The change in the internal API between brig and galley is not backward compatible, so this can cause temporary failures during upgrades. The invariant that brig's clients are a superset of galley's clients will be maintained.
Note: #3904 is a previous attempt at this fix, which overlooked the fact that the
Clientstructure is used in user events, so it was reverted.https://wearezeta.atlassian.net/browse/WPB-6400
Checklist
changelog.d