Serialisation of client capabilities #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
2 tasks
stefanwire
approved these changes
Feb 27, 2024
pcapriotti
added a commit
that referenced
this pull request
Feb 28, 2024
This reverts commit 5fa42b5.
2 tasks
echoes-hq
bot
added
the
echoes: unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an oddity in the serialisation of capabilities in the
Clientstructure.This PR replaces #3873 and simplifies the implementation. No new types are added, and the difference in serialisation is obtained using the
Versionedwrapper, which we are already using for versioned changes in serialisation.The change in the internal API between brig and galley is not backward compatible, so this can cause temporary failures during upgrades. The invariant that brig's clients are a superset of galley's clients will be maintained.
https://wearezeta.atlassian.net/browse/WPB-6400
Checklist
changelog.d