Remove puppeteer-cluster #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikreymer
reviewed
Feb 7, 2023
This commit removes puppeteer-cluster as a dependency in favor of a simpler concurrency implementation, using p-queue to limit concurrency to the number of available workers. As part of the refactor, the custom window concurrency model in windowconcur.js is removed and its logic implemented in the new Worker class's initPage method.
tw4l
force-pushed
the
issue-214-remove-puppeteer-cluster
branch
from
d4dbaf9 to
2aad268
Compare
logging: log info string / version as first line logging: improve logging of error stack traces interruption: support interrupting crawl directly with 'interrupt' check which stops the job queue interruption: don't repair if interrupting, wait for queue to be idle
|
Looks like latest changes are leading to a failure to write cdx index: https://github.com/webrecorder/browsertrix-crawler/actions/runs/4319906519/jobs/7539596680#step:6:179 |
* log text extraction update puppeteer-core * iframe filtering: - fix filtering for about:blank iframes, support non-async shouldProcessFrame() - filter iframes both for behaviors and for link extraction - add 5-second timeout to link extraction, to avoid link extraction holding up crawl! - cache filtered frames * logging: adjust info->debug logging tests: bail on first failure * init order: ensure wb-manager init called first, then logs created * healthcheck/worker reuse: - refactor healthchecker into separate class - increment healthchecker (if provided) if new page load fails - remove expermeintal repair functionality for now - add healthcheck * remove unused arg * Log no jobs available as debug --------- Co-authored-by: Tessa Walsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #214