Healthcheck + Logging Fixes + Iframe Filtering Fixes #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ikreymer
commented
Mar 6, 2023
•
ikreymer
commented
- Refactor healthchecker into own class, increment healthcheck for new page load failures
- Reuse pages (upto 5 page loads per page) before creating a new page (similar to old window-concurrency system)
- iframes: ensure blank iframes are filtered out correctly for both behaviors and link extraction
- adblock: add sync isAdUrl() check
- link extraction: set timeout to avoid hanging in link extraction
- logging: set debug logging globally
- deps: bump puppeteer-core to latest
update puppeteer-core
- fix filtering for about:blank iframes, support non-async shouldProcessFrame() - filter iframes both for behaviors and for link extraction - add 5-second timeout to link extraction, to avoid link extraction holding up crawl! - cache filtered frames
tests: bail on first failure
- refactor healthchecker into separate class - increment healthchecker (if provided) if new page load fails - remove expermeintal repair functionality for now - add healthcheck
tw4l
approved these changes
Mar 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.