Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: union utils #2343

Merged
merged 6 commits into from
Jan 12, 2021
Merged

fix: union utils #2343

merged 6 commits into from
Jan 12, 2021

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?

fix

Did you add tests for your changes?
yep

If relevant, did you update the documentation?
yes

Summary

  • This package will union utils and generators package, quite a lot of overlap

Does this PR introduce a breaking change?
Yes

Other information
Continuation of #2289

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #2343 (bba1a7c) into master (9100137) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2343      +/-   ##
==========================================
- Coverage   68.19%   68.17%   -0.02%     
==========================================
  Files          51       50       -1     
  Lines        2053     2052       -1     
  Branches      506      506              
==========================================
- Hits         1400     1399       -1     
  Misses        653      653              
Impacted Files Coverage Δ
packages/generators/src/utils/ast-utils.ts 8.26% <ø> (ø)
packages/generators/src/utils/copy-utils.ts 100.00% <ø> (ø)
...kages/generators/src/utils/global-packages-path.ts 72.72% <ø> (ø)
packages/generators/src/utils/isWebpack5.ts 100.00% <ø> (ø)
...kages/generators/src/utils/modify-config-helper.ts 57.89% <ø> (ø)
packages/generators/src/utils/npm-exists.ts 50.00% <ø> (ø)
...ckages/generators/src/utils/npm-packages-exists.ts 45.71% <ø> (ø)
packages/generators/src/utils/path-utils.ts 100.00% <ø> (ø)
packages/generators/src/utils/prop-types.ts 100.00% <ø> (ø)
packages/generators/src/utils/recursive-parser.ts 17.24% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9100137...bba1a7c. Read the comment docs.

@alexander-akait
Copy link
Member

cleanupTest is just awful 😞

@anshumanv
Copy link
Member Author

Thanks for help @alexander-akait, CI is green 💯

@alexander-akait alexander-akait merged commit debb857 into master Jan 12, 2021
@alexander-akait alexander-akait deleted the union-utils branch January 12, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants