Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: union generators and utils package #2289

Closed
wants to merge 5 commits into from

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
Not yet

If relevant, did you update the documentation?
Yet to

Summary

  • This package will union utils and generators package, quite a lot of overlap

Does this PR introduce a breaking change?
Yes, deprecating a package

Other information
/cc @alexander-akait evilebott

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's fix tests

@anshumanv
Copy link
Member Author

Some TS error 😞

@alexander-akait
Copy link
Member

@anshumanv Can you rebase and fix conflict here (many files was removed so it can be removed from here too)

@anshumanv
Copy link
Member Author

yep wip

@anshumanv
Copy link
Member Author

Done @alexander-akait, just need fix TS err

@alexander-akait
Copy link
Member

Let's merge as is, I will finish this PR in the next PR (can't finish work in fork 😞 ), we should not do it anymore in future

@alexander-akait alexander-akait marked this pull request as ready for review January 11, 2021 13:04
@alexander-akait alexander-akait requested a review from a team as a code owner January 11, 2021 13:04
@anshumanv anshumanv mentioned this pull request Jan 11, 2021
@anshumanv
Copy link
Member Author

Closing in favour of #2343

@anshumanv anshumanv closed this Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants