Update the hr-time IDL file #11862
Merged
Update the hr-time IDL file #11862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
igrigorik,
jensl,
plehegar,
toddreifsteck and
yuki3
foolip
reviewed
Jul 21, 2018
interfaces/hr-time.idl
Outdated
| readonly attribute DOMHighResTimeStamp timeOrigin; | ||
| [Default] object toJSON(); | ||
| }; | ||
|
|
||
| partial interface WindowOrWorkerGlobalScope { | ||
| partial interface mixin WindowOrWorkerGlobalScope { |
There was a problem hiding this comment.
Typo in spec here? Doesn't this parse error break the test entirely?
There was a problem hiding this comment.
What's supposed to be a typo?
EDIT: discussed offline; it is supposed to be interface mixin (not just mixin).
lukebjerring
force-pushed
the
idl-file-updates-hr-time
branch
from
0f60ab7 to
e2deb12
Compare
|
Tweaked the test to cover |
lukebjerring
force-pushed
the
idl-file-updates-hr-time
branch
from
e2deb12 to
0229a36
Compare
foolip
approved these changes
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello reviewer(s),
This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.
The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.
This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.
Please check that:
The spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the
interfaces/directory (instead of inline copies in the test files).