Add snap package definition

[fbarl]

This PR should enable users to install wksctl via snap command on Ubuntu systems.

Used a mix of https://snapcraft.io/docs/go-applications and fluxcd/flux template for the snapcraft.yaml draft (thanks @dholbach for leaving enough traces around :)).

Checklist

• Add snapcraft.yaml that compiles into a working binary
• Verify and tighten all the interface permissions
  • Switched to classic confinement as wksctl needs to read files passed to it via command line args, like --cluster and --machines args in wksctl apply, and we don't know where those file might be stored locally
  • Will be using strict confinement - see the store request discussion for the full context
• Test out basic wksctl commands in the snap install
• Publish the snap package
  • Resolve the store request manual review
  • Release to edge
  • Release to stable
• Update the package metadata - https://snapcraft.io/wksctl/listing
  • Update publisher account details (full name, username, email address) to point to Weaveworks instead of a personal account
  • Add a snap icon - Create a logo #77
  • Add video, images, featured banner
  • Add contact email
• Update the docs with snap install instructions
  • Will do once we have the stable release pushed

TODO in follow-up PRs

• Integrate with Github for automatic snap version updates - https://snapcraft.io/build
  • Sync with @dholbach on this one as fluxctl and eksctl might need the same

[dholbach]

I think it'd be good to start setting up the account. Registration of the package (or was it initial review?) took a while, if memory serves.

… and if it's just a placeholder version

[dholbach]

https://github.com/fluxcd/flux/blame/master/snap/snapcraft.yaml#L23-L37 might be helpful for automatically getting you the version.

[dlespiau]

goreleaser can do snap packages. That seems like a nice to way to do snaps as we already are using goreleaser: https://goreleaser.com/snapcraft/

[dholbach]

goreleaser can do snap packages. That seems like a nice to way to do snaps as we already are using goreleaser: https://goreleaser.com/snapcraft/

If the snap part of goreleaser work for you, great. AFAIUI it only exposes a subset of what's available through snapcraft.yaml. I have no experience there.

[fbarl]

goreleaser can do snap packages. That seems like a nice to way to do snaps as we already are using goreleaser: https://goreleaser.com/snapcraft/

Thanks for the suggestion! I did come across it but only after I had a buildable snapcraft.yaml so I wouldn't switch to it in this PR if this works. However, we might reconsider this decision later when branching out to other platforms, e.g. https://github.com/weaveworks/wks/issues/839.

[fbarl]

The PR is currently blocked by manual approval that is needed from the snapcraft folks because wksctl needs to be able to break the snap confinement to read custom YAML files - https://forum.snapcraft.io/t/classic-confinement-for-wksctl/13383/2

[dholbach]

Why don't you merge for now and then iterate with feedback from the store people?

[fbarl]

Why don't you merge for now and then iterate with feedback from the store people?

I don't think we'd add any value to the codebase if we merged it as it is before we'd:

• At least be able to push to the edge channel
• Document how to push new versions

It might be confusing if snapcraft.yaml appeared in the master branch but was basically ineffective and besides I don't mind keeping the draft PR open as a personal reminder that it will need more of my attention later :)

[fbarl]

Closing this PR due to inactivity (although I understand this work might be picked up again in the future).

[dholbach]

fluxcd/flux#3072 might be of interest at some stage.