-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
https://github.com/dholbach/flux/runs/699917271 looks good! :-) |
✔️ https://github.com/dholbach/flux/runs/708796834 (with snapcraft_token added to my repo too). |
To add some background: for every commit to
Up until now I did this all manually (for releases and for commits in master every other day), because we were blocked by canonical-web-and-design/build.snapcraft.io#1191 (to set up the webhook automatically, build.snapcraft.io wanted very broad privileges). This would automate it all away. |
For every commit to master, this GH Action workflow - builds the snap using snap/snapcraft.yaml - if it's a tagged release, upload the resulting snap to the stable channel of the snap - if not, upload the resulting snap to the edge channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the basis that I this demonstrably works, and I can see how to debug it when it doesn't, I approve this PR. Thanks Daniel! 🍍
Firefox says it's "Let's Encrypt". 🤷 |
I guess I can just exclude |
@dholbach it might also be solved by updating the |
💡 |
Apparently it was already installed, so I'll remove it again and exclude |
Retrying #3034 after reading samuelmeuli/action-snapcraft#11 (comment)
Build snap using GH action... next steps: