Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use memcache in local #542

Merged
merged 2 commits into from
Jun 30, 2016
Merged

Use memcache in local #542

merged 2 commits into from
Jun 30, 2016

Conversation

jml
Copy link

@jml jml commented Jun 20, 2016

Updates the local deployment to use memcached. Also provides graphs for memcached.

Part of the fix for #442. Depends on weaveworks/scope#1602.

@@ -5,8 +5,11 @@ metadata:
annotations:
prometheus.io.port: "9150"
spec:
# The memcache client uses DNS to get a list of memcached servers and then
# uses a consistent hash of the key to determine which server to pick.
clusterIP: None

This comment was marked as abuse.

@tomwilkie
Copy link

tomwilkie commented Jun 21, 2016

  • Can we have the memcache bits in the dashboard come before s3?
  • Don't bother with server side QPS and hit ratio.
  • Put latency on the same row as QPS pls.
  • Can we get some mearue for memory pressure in memcache? I guess we'd see this as a lower hit rate, so not super important.

@tomwilkie
Copy link

Is there any limit to the size of these memcaches?

@jml
Copy link
Author

jml commented Jun 23, 2016

All done. Added memory capacity graph to memcache, showing current bytes ÷ total bytes allowed.

Added explicit option to rc file for maximum memory size. Default is 64MB.

PTAL.

@jml jml removed their assignment Jun 23, 2016
@tomwilkie
Copy link

Have run this locally, and dashboard is good.

However, I have a few concerns (which shouldn't block this PR):

  • I still seem to be doing S3 gets. I was expecting this to mean we do basically no gets from S3?
  • Similarly, why is the hit rate not 100%
  • At least locally, the memcache get latency is quite high (3-400ms at 99th). I wasn't expecting this.

I suggest we get this merged and then investigate this some more in the dev environment.

@tomwilkie tomwilkie assigned jml and unassigned tomwilkie Jun 24, 2016
@jml jml merged commit 0905467 into master Jun 30, 2016
@jml jml deleted the use-memcache branch June 30, 2016 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants