Query memcached from dynamo db collector #1602
Conversation
| Namespace: "scope", | ||
| Name: "memcache_miss", | ||
| Help: "Reports that missed both our in-memory cache and our memcache", | ||
| }) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Updated. PTAL. I'm going to do some local testing. |
|
Done some more local testing -- everything works. Note: after scaling replicas, SRV resolution seems to fail until I delete & recreate the k8s memcached-svc |
| err := updateMemcacheServers(memcachedHost, memcachedService, &memcacheServers) | ||
| if err != nil { | ||
| // REVIEWER: Undecided whether this should exit or not. Thoughts? | ||
| log.Errorf("Could not set memcache servers: %v", err) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@jml I've left quite a few comments, let me know if you want to discuss. Am going to test now, but will assign back to you for the time being to address these comments. |
|
@tomwilkie Thanks for the thorough review. I've responded to all of your comments & have followed your suggestions on most. PTAL. |
| @@ -59,6 +54,12 @@ var ( | |||
| Help: "Size of data read / written from dynamodb.", | |||
| }, []string{"method"}) | |||
|
|
|||
| inProcessCacheCounter = prometheus.NewCounterVec(prometheus.CounterOpts{ | |||
| Namespace: "scope", | |||
| Name: "dynamo_cache", // TODO(jml): Rename this monitoring variable. | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| ticker := time.NewTicker(updateInterval) | ||
| go func() { | ||
| for range ticker.C { | ||
| updateMemcacheServers(host, service, &servers) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@tomwilkie All responded. PTAL. |
|
LGTM once green. |
|
And a big squash! |
If given settings for memcached, services will store & fetch reports from memcache after checking their in-process cache but before fetching from S3.
timeRequestto parametrize the error -> status behaviourThis change is