Convert to Go modules #3742
Merged
Convert to Go modules #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created by running `go mod init`; all versions the same as before.
Without this we get a build error: github.com/Sirupsen/logrus: github.com/Sirupsen/[email protected]: parsing go.mod: module declares its path as: github.com/sirupsen/logrus but was required as: github.com/Sirupsen/logrus
This was useful to cache dependent library builds, but Go does that better now so we don't need the flag.
Need workaround until a fix upstream such as https://github.com/iovisor/gobpf/pull/206/files is merged.
fbarl
reviewed
Jan 14, 2020
|
Thanks for taking your time with this @bboreham! Good catch with the last commit as well, as you mentioned Overall, the code looks good, wanted to look into the build and test the behavior quickly! :) |
This is a small program used to watch app and probe running inside the container. We need to go round a few houses to be able to build it from vendor directory.
There is no way to pass `-mod=vendor` through to the Go compilation that codecgen runs.
This bit is unnecessary with newer versions of Go that cache builds for different tags in different places.
|
I made weaveworks/tcptracer-bpf#69 to avoid the manual copy for one file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done by running
go mod initthen fixing compilation errors thengo mod vendor.A few C files needed to be manually added.
There are a lot of files moved or deleted, because
go mod vendorflattens dependencies at the top level and the previous tool,gvt, did not.