-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move header files in the same folder than Go files #206
Conversation
27ec169
to
f9e9df8
Compare
@alban Can you please have a look ? Thank you ! |
If I understand correctly, this is to resolve the same problem described at golang/go#26366 (comment) 👍 from me. |
LGTM (after the conflict is resolved) |
@lebauce could you please solve the conflict? |
0c798fc
to
f9a066d
Compare
@alban Do you think we could remove the "do-not-merge" tag ? Thanks ! |
Hi @lebauce, sorry for the big delay. I believe we can't merge this PR, as described in #234, some of the files we pull from the kernel expect a I think we should move ahead and merge #217 then. |
@mauriciovasquezbernal Thanks for your explanation. It perfectly makes sense. Can we then move forward and merge #217 (once the doc.go file is also added to elf/include, elf/include/linux, elf/include/uapi, elf/include/uapi/linux and elf/lib) ? |
When using iovisor/gobpf from a project using Go modules, the bpf.h and bpf_map.h files and not imported as they are in the
include
subdirectory.This fix makes it possible to use gobpf in a
go.mod
file.