Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move header files in the same folder than Go files #206

Closed
wants to merge 1 commit into from

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Sep 9, 2019

When using iovisor/gobpf from a project using Go modules, the bpf.h and bpf_map.h files and not imported as they are in the include subdirectory.
This fix makes it possible to use gobpf in a go.mod file.

@lebauce
Copy link
Contributor Author

lebauce commented Oct 4, 2019

@alban Can you please have a look ? Thank you !

@bboreham
Copy link

If I understand correctly, this is to resolve the same problem described at golang/go#26366 (comment)

👍 from me.

@alban
Copy link
Collaborator

alban commented Jan 17, 2020

LGTM (after the conflict is resolved)

@mauriciovasquezbernal
Copy link
Collaborator

@lebauce could you please solve the conflict?

@lebauce
Copy link
Contributor Author

lebauce commented Apr 7, 2020

@alban @bboreham Seems like I completely missed the notifications on this one. I just rebased my PR. Sorrry for the delay

@lebauce
Copy link
Contributor Author

lebauce commented May 4, 2020

@alban Do you think we could remove the "do-not-merge" tag ? Thanks !

@lebauce lebauce requested a review from alban May 5, 2020 07:48
@mauriciovasquezbernal
Copy link
Collaborator

Hi @lebauce, sorry for the big delay. I believe we can't merge this PR, as described in #234, some of the files we pull from the kernel expect a linux/filename.h structure, if we move everything into the same folder we'll have to modify all those files making it difficult to maintain.

I think we should move ahead and merge #217 then.

@lebauce
Copy link
Contributor Author

lebauce commented May 27, 2020

@mauriciovasquezbernal Thanks for your explanation. It perfectly makes sense. Can we then move forward and merge #217 (once the doc.go file is also added to elf/include, elf/include/linux, elf/include/uapi, elf/include/uapi/linux and elf/lib) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants