Use unsafe merge in joinResults.addChildAndChildren() #3143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed from #3138. It's a bug as-is -
Merge()
can return the rhs which is not safe to do further 'unsafe' operations on.Benchmarks show the impact is mixed:
Also comment the
add()
call introduced in #3135 is inconsistent with #3138 - no impact as the two sets of calls are never used together, but it's not ideal. Changingadd()
to copy children makes performance worse.