Use single-owner code path to accumulate children when rendering #3138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added
ps.Map.UnsafeMutableSet()
to optimise the case where you know a NodeSet is not shared with any other nodes. We can arrange this quite easily for theChildren
of each node injoinResults
, hence speed up rendering.I had to adjust the smart/dumb merger benchmarks when they showed an improvement, which is spurious because this code isn't involved in merging.
Benchmarks comparison between first commit and last commit: