Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve view-node-in-topo button usability #1926

Merged
merged 6 commits into from
Nov 4, 2016
Merged

Improve view-node-in-topo button usability #1926

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1e6c465
Current topo follows details panel!
foot Oct 13, 2016
05cd10c
Revert "Current topo follows details panel!"
foot Oct 13, 2016
dc61317
Bring shapes into the details panel and use them for view-in-topo
foot Oct 17, 2016
30bca04
Revert "Bring shapes into the details panel and use them for view-in-…
foot Nov 3, 2016
4da2a82
Add label to show-in-topo button
foot Nov 3, 2016
fe2bfe2
Use the familiar ALLCAPS for topo name in show-in-topo button
foot Nov 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add label to show-in-topo button
  • Loading branch information
@foot
foot committed Nov 3, 2016
commit 4da2a826028278156e1e0185d42868f4d95e245d
4 changes: 3 additions & 1 deletion client/app/scripts/components/node-details.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ export class NodeDetails extends React.Component {
<div className="node-details-tools-wrapper">
<div className="node-details-tools">
{showSwitchTopology && <span title={topologyTitle}
className="fa fa-exchange" onClick={this.handleShowTopologyForNode} />}
className="fa fa-long-arrow-left" onClick={this.handleShowTopologyForNode}>
<span>View in {this.props.topologyId}</span>
</span>}
<span title="Close details" className="fa fa-close" onClick={this.handleClickClose} />
</div>
</div>
Expand Down
10 changes: 8 additions & 2 deletions client/app/styles/main.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,15 +619,21 @@ h2 {
top: 6px;
right: 8px;

span {
> span {
.btn-opacity;
padding: 4px 5px;
margin-left: 2px;
font-size: 110%;
color: @white;
cursor: pointer;
border: 1px solid rgba(255, 255, 255, 0);
border-radius: 10%;
border-radius: 4px;

span {
font-family: @base-font;
font-size: 0.9em;
margin-left: 4px;
}

&:hover {
border-color: rgba(255, 255, 255, 0.6);
Expand Down