-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve view-node-in-topo button usability #1926
Conversation
I agree, it's not clear what the control will do. The same is true for the old button, so I see no improvement here. In these situations I suggest to use a plain text label to describe what the button will do.
Yes, I would find that confusing, because at that point you're in the context of a node, the change of a topology would be too big. There is another option, let's simply remove the button, and see if anyone complains. |
"Find in Topology"? "Find in Graph"? "Find"?
The fact that the single button changes a lot is exactly what makes it useful. |
This reverts commit 7a5e04f.
(click on shape/title to view it in its topo)
…topo" This reverts commit 1bf54130ffb4e6c83f0bd816f7a037f819d561ac.
6e15a7c
to
30bca04
Compare
"View"? "Find"? "Locate"? |
I like View! Find/Locate sound expensive like we're gonna have to do some work to perform that action... but maybe that works well in envs where it takes a couple of seconds to load up the next topo. j/k! I like: View / Show Wonder if there is webpack module to thesaursize all your copy. |
I quite like that. |
Circle fails on BE test. |
Code and copy LGTM |
Fixes #1151