Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve view-node-in-topo button usability #1926

Merged
merged 6 commits into from
Nov 4, 2016

Conversation

foot
Copy link
Contributor

@foot foot commented Oct 17, 2016

Fixes #1151

@davkal
Copy link
Contributor

davkal commented Oct 18, 2016

IMO it's not obvious that the shape is a control. Let alone what that control will do.

I agree, it's not clear what the control will do. The same is true for the old button, so I see no improvement here. In these situations I suggest to use a plain text label to describe what the button will do.

navigation in a sub-view updating the whole UI, a lot of things changing in reaction to following a link.

Yes, I would find that confusing, because at that point you're in the context of a node, the change of a topology would be too big.

There is another option, let's simply remove the button, and see if anyone complains.

@rade
Copy link
Member

rade commented Oct 18, 2016

In these situations I suggest to use a plain text label to describe what the button will do.

"Find in Topology"? "Find in Graph"? "Find"?

There is another option, let's simply remove the button,

The fact that the single button changes a lot is exactly what makes it useful.

@foot foot force-pushed the 1151-improve-view-node-in-topo branch from 6e15a7c to 30bca04 Compare November 3, 2016 10:10
@foot
Copy link
Contributor Author

foot commented Nov 3, 2016

screen shot 2016-11-03 at 12 39 49

testing out labels. feels pretty good.

@rade
Copy link
Member

rade commented Nov 3, 2016

"View"? "Find"? "Locate"?

@foot
Copy link
Contributor Author

foot commented Nov 3, 2016

I like View! Find/Locate sound expensive like we're gonna have to do some work to perform that action... but maybe that works well in envs where it takes a couple of seconds to load up the next topo. j/k!

I like: View / Show
Also: Focus / Examine / Inspect / Select
Thesaurus provides: Behold / Witness / Scrutinise.

Wonder if there is webpack module to thesaursize all your copy.

@foot
Copy link
Contributor Author

foot commented Nov 3, 2016

screen shot 2016-11-03 at 15 50 43

Another variant w/ the more familiar ALLCAPS topology label.

@rade
Copy link
Member

rade commented Nov 4, 2016

I quite like that.

@davkal
Copy link
Contributor

davkal commented Nov 4, 2016

Circle fails on BE test.

@davkal
Copy link
Contributor

davkal commented Nov 4, 2016

Code and copy LGTM

@davkal davkal merged commit 0594ec7 into master Nov 4, 2016
@davkal davkal deleted the 1151-improve-view-node-in-topo branch November 4, 2016 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants