Fixes left alignment of numbers in the details panel tables #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- By declaring more things to be numbers - Also fixes initial sort direction of number columns from asc to desc.
foot
force-pushed
the
1794-fixes-left-alignment-number-cols
branch
from
3567740 to
7c4654d
Compare
rade
suggested changes
Sep 21, 2016
| @@ -38,6 +38,7 @@ type Column struct { | |||
| ID string `json:"id"` | |||
| Label string `json:"label"` | |||
| DefaultSort bool `json:"defaultSort"` | |||
| DataType string `json:"dataType"` | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| {ID: portKey, Label: portLabel}, | ||
| {ID: countKey, Label: countLabel, DefaultSort: true}, | ||
| {ID: portKey, Label: portLabel, DataType: "number"}, | ||
| {ID: countKey, Label: countLabel, DataType: "number", DefaultSort: true}, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
- Rename DataType -> Datatype for consisitency - Remove Datatype from connection.metadata - Change UI to read dataType from connection.columns rather than from connection.metadata (col header rather than "cell")
rade
approved these changes
Sep 22, 2016
|
LGTM |
This was referenced Sep 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1794