Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet connection detail remotes not sorted correctly #1869

Closed
rade opened this issue Sep 15, 2016 · 3 comments
Closed

Internet connection detail remotes not sorted correctly #1869

rade opened this issue Sep 15, 2016 · 3 comments
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer

Comments

@rade
Copy link
Member

rade commented Sep 15, 2016

screenshot_2016-09-15_19-36-07

This is meant to be in descending order but clearly isn't.

That is because the b/e tells the f/e that this column is numeric. The f/e converts the value to a float, which in case of an IP address catches the first two octets, but in case of a DNS name just returns "NaN".

@rade rade added the bug Broken end user or developer functionality; not working as the developers intended it label Sep 15, 2016
@rade
Copy link
Member Author

rade commented Sep 15, 2016

for table mode we decided to sort alphabetically to begin with, and filed #1746 to do better. I suggest we do the same here.

@rade rade modified the milestone: 0.18/1.0 Sep 15, 2016
@foot foot assigned foot and unassigned foot Sep 21, 2016
@rade
Copy link
Member Author

rade commented Sep 26, 2016

I think this got fixed by #1877. @foot pls confirm

@rade rade added the component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer label Sep 27, 2016
@foot
Copy link
Contributor

foot commented Sep 27, 2016

Correct, #1877 removed dataType: number from remote and thus the attempt at numeric sorting.

@rade rade closed this as completed Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Development

No branches or pull requests

2 participants