Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for block profiling #1681

Merged
merged 3 commits into from
Jul 14, 2016
Merged

Add flag for block profiling #1681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ddc91f
Add flag for block profiling
jml Jul 14, 2016
7894442
Update site/building.md with profiling docs
jml Jul 14, 2016
0edd2e7
Oops
jml Jul 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions prog/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
_ "net/http/pprof"
"net/url"
"os"
"runtime"
"strconv"
"strings"
"time"
Expand Down Expand Up @@ -199,6 +200,7 @@ func pipeRouterFactory(userIDer multitenant.UserIDer, pipeRouterURL, consulInf s
func appMain(flags appFlags) {
setLogLevel(flags.logLevel)
setLogFormatter(flags.logPrefix)
runtime.SetBlockProfileRate(flags.blockProfileRate)

defer log.Info("app exiting")
rand.Seed(time.Now().UnixNano())
Expand Down
4 changes: 4 additions & 0 deletions prog/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ type appFlags struct {
memcachedExpiration time.Duration
userIDHeader string

blockProfileRate int

awsCreateTables bool
consulInf string
}
Expand Down Expand Up @@ -197,6 +199,8 @@ func main() {
flag.StringVar(&flags.app.memcachedService, "app.memcached.service", "memcached", "SRV service used to discover memcache servers.")
flag.StringVar(&flags.app.userIDHeader, "app.userid.header", "", "HTTP header to use as userid")

flag.IntVar(&flags.app.blockProfileRate, "app.block.profile.rate", 0, "If more than 0, enable block profiling. The profiler aims to sample an average of one blocking event per rate nanoseconds spent blocked.")

flag.BoolVar(&flags.app.awsCreateTables, "app.aws.create.tables", false, "Create the tables in DynamoDB")
flag.StringVar(&flags.app.consulInf, "app.consul.inf", "", "The interface who's address I should advertise myself under in consul")

Expand Down
6 changes: 6 additions & 0 deletions site/building.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@ To collect the CPU profile of the Scope Probe:

go tool pprof http://localhost:4041/debug/pprof/profile

To collect a blocking profile of the Scope App, make sure you have launched
Scope with `--app.block.profile.rate=N` (where `N` is the number of
nanoseconds between samples) and then:

go tool pprof http://localhost:4040/debug/pprof/block

If you don't have `go` installed, you can use a Docker container instead:

To collect the memory profile of the Scope App:
Expand Down