-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag for block profiling #1681
Conversation
Fixes #1672 Test by adding `--app.block.profile.rate=1`, running scope in multi-tenant mode and browsing to http://<scope-url>/debug/pprof/
Isn't this flag a bit fine-grained? How about simply enabling block profiling with a default value when supplying Also, could you please update |
Another option is adding something like (these are just suggestions, it's ultimately up to you) |
Thinking about it a bit more, in the documentation it seems we separate debugging (showing more info in the logs) from profiling so feel free to ignore my comments about the flag names. |
I anticipate that we'll get the default value wrong & will want to iterate quickly. Flags are the best way we currently have of doing that.
Having one flag for both app & probe seems like a good idea. Does your other comment about separating debug from profiling preclude this as a flag name? |
Probably, at least we separate them in the docs. |
Scope with `--app.block.profile.rate=N` (where `N` is the number of | ||
nanoseconds between samples) and then: | ||
|
||
go tool pprof http://localhost:4040/debug/pprof/ |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
LGTM (provided you get a green from circle) |
Fixes #1672
Test by adding
--app.block.profile.rate=1
, running scope inmulti-tenant mode and browsing to http:///debug/pprof/
This change is