Plugins #1126

paulbellamy · 2016-03-04T17:34:33Z

Fixes #554

Commits are still super-messy, and tests are earmarked, as this is both a work-in-progress and a proof-of-concept.

HTTP Request latency is shown on the weavescope node (we can correlate it due to weavescope being in the host network).

Plugin registry turned out very similar to #809.

TODO:

paulbellamy · 2016-03-04T17:49:54Z

@davkal should we display in the UI which plugins are enabled? what would be a good way of displaying this?

davkal · 2016-03-07T14:19:44Z

Yes, let's place it in the bottom left for now, because

it's a status
it may have multiple entries/rows that can stack nicely

Some thing like:

10 NODES (408 FILTERED)
Stopped containers hidden SHOW
System containers hidden SHOW
[plugin icon] pluginX, pluginY

The DS could be as simple as [{id, label, description},...]. The description would show on hover. If plugins support a state (on/off), we can add that too.

paulbellamy · 2016-03-07T14:42:10Z

In order to get more/better data from the sysdig probe the best plan seems to be using the "chisel" system, which are a bunch of lua scripts sysdig can run. We could just capture the event stream, but that will likely lead to a lot of unneeded serialization/deserialization.

We could either write individual chisels for bits they have, and plumb them through, or we could look into writing one generic meta-chisel which would let us dynamically grab bits and do queries. We could either implement the entire plugin in lua (probably? There seems to be a jsonrpc library for lua), or we could do the barebones filtering/querying in the lua chisel, and drive that from a go plugin.

I've included a http_txns_by_pid.lua chisel (based on the existing httplog one), as an example of a chisel which would format the data for a specific query. It adds inbound/outbound http request rates to process nodes.

Some other things we could potentially get from the sysdig probe:

bandwidth usage
protocol detection/inspection
more http metrics (latency, error rates, error codes, avg size, breakdown by endpoints/hosts/etc)
same for other protocols (memcached, redis, etc)
might be able to tie in with tracing?
- could maybe even do "session capture", like chrome's network request logging
unix socket connections
socket queue lengths
slow system calls / system call length

app/router.go

-		Version:  Version,
-		Hostname: hostname.Get(),
-	})
+func apiHandler(rep Reporter) func(context.Context, http.ResponseWriter, *http.Request) {


tomwilkie · 2016-03-08T12:15:33Z

First quick pass says its looking good.

I'm thinking plugins/ should be moved into probe/, with some of the common datatypes moved into report.

paulbellamy · 2016-03-08T12:35:23Z

I'm thinking plugins/ should be moved into probe/, with some of the common datatypes moved into report.

I'm not so sure on that yet. I tried it moving it into probe/, but it was a bit odd since it's required by report and render as well. By the time we do control and pipe plugins (and wire all that through the UI) it would probably have hooks used all over. We could split the common datatypes into report, but it is sort of nice to be able to re-use them between the registry and the rest of the code.

I had a vague eye to keeping the plugin registry and lifecycle-management code separate so it could be extracted into a separate library at some point.

Will see about refactoring it as it goes.

tomwilkie · 2016-03-08T12:42:17Z

We could split the common datatypes into report, but it is sort of nice to be able to re-use them between the registry and the rest of the code.

This is what I'd do - see controls; common stuff goes in common/xfer or report, probe specific stuff in probe and app specific stuff in app.

Whilst I don't feel particularly strongly about this, it would be nice if this was consistent across the whole code base, where 'vertical' features are split up like this. It used to make a difference on build times, but now we just build on big binary.

probe/plugins/registry.go

+
+// Registry maintains a list of available plugins by name.
+type Registry struct {
+	root              string


paulbellamy · 2016-04-12T14:46:14Z

Raised separate issue for indicating broken plugins in the UI.

examples/plugins/http-requests/http-requests.py

-            'api_version': '1',
-        }
-        self.respond(json.dumps(spec))
-
    def respond(self, body):


2opremio · 2016-04-12T15:58:08Z

LGTM, (I would like to have #1271 for the release though)

Squash of: * Include plugins in the report * show plugin list in the UI * moving metric and metadata templates into the probe reports * update js for prime -> priority * added retry to plugin handshake * added iowait plugin * review feedback * plugin documentation

* It sends unexpected TCP RSTs (causing connection reset by peer errors in the python plugin) Exception happened during processing of request from Traceback (most recent call last): File "/usr/lib/python2.7/SocketServer.py", line 295, in _handle_request_noblock self.process_request(request, client_address) File "/usr/lib/python2.7/SocketServer.py", line 321, in process_request self.finish_request(request, client_address) File "./http-requests.py", line 145, in finish_request self.RequestHandlerClass(request, '-', self) File "/usr/lib/python2.7/SocketServer.py", line 658, in __init__ self.handle() File "/usr/lib/python2.7/BaseHTTPServer.py", line 349, in handle self.handle_one_request() File "/usr/lib/python2.7/BaseHTTPServer.py", line 312, in handle_one_request self.raw_requestline = self.rfile.readline(65537) File "/usr/lib/python2.7/socket.py", line 480, in readline data = self._sock.recv(self._rbufsize) error: [Errno 104] Connection reset by peer * It doesn't reuse connections

examples/plugins/README.md

+
+```json
+{
+  "Processes: { ... }


2opremio · 2016-04-12T17:45:34Z

Awesome job @paulbellamy! \o/

alepuccetti · 2016-09-22T08:35:12Z

Should this PR fix also #1022?

2opremio · 2016-09-22T12:40:07Z

@alepuccetti I think you are referring to #1837 , not this PR

paulbellamy force-pushed the plugins branch 2 times, most recently from ec2f8dc to f1e935b Compare March 4, 2016 17:42

paulbellamy force-pushed the plugins branch from 14a20a8 to e145ca2 Compare March 7, 2016 14:19

paulbellamy force-pushed the plugins branch 2 times, most recently from e145ca2 to f485f2e Compare March 8, 2016 09:17

tomwilkie reviewed Mar 8, 2016
View reviewed changes

app/router.go

Version: Version,

Hostname: hostname.Get(),

})

func apiHandler(rep Reporter) func(context.Context, http.ResponseWriter, *http.Request) {

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

paulbellamy force-pushed the plugins branch 3 times, most recently from 9c51e0c to 0a49f7c Compare March 14, 2016 11:47

paulbellamy mentioned this pull request Mar 15, 2016

More complete node summary #1169

Closed

paulbellamy force-pushed the plugins branch from 0a49f7c to f0ce2f5 Compare March 15, 2016 12:59

paulbellamy force-pushed the plugins branch 2 times, most recently from b65c2ef to 87f008e Compare March 29, 2016 15:41

paulbellamy self-assigned this Mar 30, 2016

paulbellamy force-pushed the plugins branch 3 times, most recently from 7c22443 to 90fb733 Compare March 31, 2016 13:47

2opremio reviewed Apr 4, 2016
View reviewed changes

probe/plugins/registry.go

// Registry maintains a list of available plugins by name.

type Registry struct {

root string

This comment was marked as abuse.

Sign in to view

2opremio reviewed Apr 12, 2016
View reviewed changes

examples/plugins/http-requests/http-requests.py

'api_version': '1',

}

self.respond(json.dumps(spec))

def respond(self, body):

This comment was marked as abuse.

Sign in to view

paulbellamy force-pushed the plugins branch from 4b7cfcc to 3ce5b11 Compare April 12, 2016 15:09

paulbellamy and others added 14 commits April 12, 2016 17:20

adding github.com/paypal/ionet for testing

f899f44

removing render/detailed/labels, as its not a good fit anymore

6b0795a

Moved plugins renderer to the status footer

f79a49b

Review feedback - adding plugin status field

fcfd42e

Review Feedback

333d32f

ebpf plugin to gather http-request rate per PID

2da13da

Add dependencies for building docker image

efd62ac

Review feedback

dfa93fe

Review feedback: rename plugin directory

30bd651

ditch plugin handshake endpoint

16c497d

add .uptodate to gitignore (for http-requests example plugin)

4b4e523

iowait example plugin should remove the socket when done

72518e7

paulbellamy force-pushed the plugins branch from 3ce5b11 to 72518e7 Compare April 12, 2016 16:22

tomwilkie reviewed Apr 12, 2016
View reviewed changes

examples/plugins/README.md

```json

{

"Processes: { ... }

This comment was marked as abuse.

Sign in to view

paulbellamy added 2 commits April 12, 2016 17:44

typo in plugins readme

a9aaac0

use json template in iowait example, as it's clearer

3865e0f

paulbellamy merged commit f211d48 into master Apr 12, 2016

paulbellamy deleted the plugins branch April 12, 2016 17:03

alepuccetti mentioned this pull request Sep 22, 2016

Probe plugins should be able to add controls. #1022

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Plugins #1126

Plugins #1126

paulbellamy commented Mar 4, 2016

paulbellamy commented Mar 4, 2016

davkal commented Mar 7, 2016

paulbellamy commented Mar 7, 2016

This comment was marked as abuse.

This comment was marked as abuse.

tomwilkie commented Mar 8, 2016

paulbellamy commented Mar 8, 2016

tomwilkie commented Mar 8, 2016

This comment was marked as abuse.

paulbellamy commented Apr 12, 2016

This comment was marked as abuse.

2opremio commented Apr 12, 2016

This comment was marked as abuse.

2opremio commented Apr 12, 2016

alepuccetti commented Sep 22, 2016

2opremio commented Sep 22, 2016

Plugins #1126

Plugins #1126

Conversation

paulbellamy commented Mar 4, 2016

paulbellamy commented Mar 4, 2016

davkal commented Mar 7, 2016

paulbellamy commented Mar 7, 2016

This comment was marked as abuse.

This comment was marked as abuse.

tomwilkie commented Mar 8, 2016

paulbellamy commented Mar 8, 2016

tomwilkie commented Mar 8, 2016

This comment was marked as abuse.

paulbellamy commented Apr 12, 2016

This comment was marked as abuse.

2opremio commented Apr 12, 2016

This comment was marked as abuse.

2opremio commented Apr 12, 2016

alepuccetti commented Sep 22, 2016

2opremio commented Sep 22, 2016