Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe plugins should be able to add controls. #1022

Closed
alban opened this issue Feb 24, 2016 · 8 comments
Closed

Probe plugins should be able to add controls. #1022

alban opened this issue Feb 24, 2016 · 8 comments
Labels
feature Indicates that issue is related to new end user functionality

Comments

@alban
Copy link
Contributor

alban commented Feb 24, 2016

I would like to have control plugins in Weave Scope so users could do more actions on containers from the Scope UI. See also #554 for similar ideas on probe plugins.

My use case is to simulate bad network in containers with the netem queuing discipline. I would like users to be able to configure latency, bandwidth, percentage packet drop on egress and ingress for each connection. The Scope UI would take care of sending the commands to the right node and the actual work of configuring the traffic control rules could be delegated to a control plugin.

I started to write a daemon that receives commands on D-Bus to configure the traffic control rules:
https://github.com/kinvolk/tcd
A traffic control plugin for Scope could either send the D-Bus commands to tcd, or just include the golang code to do the job.

@tomwilkie
Copy link
Contributor

I plan on doing this as part of #554. Maybe get a chance next week.

@faddat
Copy link
Contributor

faddat commented Feb 25, 2016

@alban @tomwilkie okay BUT

Can you please call the "bad network" mode "comcast"?

@tomwilkie tomwilkie changed the title RFC: control plugins for traffic control Probe plugins should be able to add controls. Apr 19, 2016
@tomwilkie
Copy link
Contributor

We've added plugins in 0.14, but they don't have the ability to respond to control requests yet.

We're probably not going to add it in 0.15 unless the feedback on plugins is very strong. But its a candidate for 0.16.

@faddat
Copy link
Contributor

faddat commented Apr 19, 2016

This isn't something I am in a desperate hurry for, but I do want to say
that it sounds positively awesome :).

On Tue, Apr 19, 2016, 22:19 Tom Wilkie [email protected] wrote:

We've added plugins in 0.14, but they don't have the ability to respond to
control requests yet.

We're probably not going to add it in 0.15 unless the feedback on plugins
is very strong. But its a candidate for 0.16.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#1022 (comment)

@alban
Copy link
Contributor Author

alban commented May 3, 2016

/cc @alepuccetti

@faddat
Copy link
Contributor

faddat commented May 4, 2016

@Ozzadar

@rade rade added the feature Indicates that issue is related to new end user functionality label Jul 4, 2016
@rade rade modified the milestone: icebox Jul 4, 2016
@alepuccetti
Copy link

alepuccetti commented Sep 22, 2016

In the traffic control plugin, we add controls from the plugin into the container details view.
I suppose that this issue can be closed by #1126 or I am missing something?

This was referenced Sep 22, 2016
@2opremio
Copy link
Contributor

Yes, but it's closed by #1837

@rade rade modified the milestones: 0.18/1.0, icebox Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates that issue is related to new end user functionality
Projects
None yet
Development

No branches or pull requests

6 participants