Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for symbol maps #294

Merged
merged 11 commits into from
Mar 28, 2019
Merged

add support for symbol maps #294

merged 11 commits into from
Mar 28, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

resolves #293

@MarkMcCaskey MarkMcCaskey added the 🎉 enhancement New feature! label Mar 26, 2019
bjfish
bjfish reviewed Mar 27, 2019
View reviewed changes
lib/runtime-core/src/vm.rs Outdated Show resolved Hide resolved
@MarkMcCaskey MarkMcCaskey marked this pull request as ready for review March 27, 2019 21:36
@xmclark xmclark self-requested a review March 27, 2019 21:39
xmclark
xmclark reviewed Mar 27, 2019
View reviewed changes
Copy link
Contributor

@xmclark xmclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post an image of some typical output with the symbols?

@MarkMcCaskey MarkMcCaskey mentioned this pull request Mar 27, 2019
Merged
@MarkMcCaskey
Copy link
Contributor Author

Can you post an image of some typical output with the symbols?

Sure!

Screen Shot 2019-03-27 at 15 35 25

@MarkMcCaskey
Copy link
Contributor Author

Also, as a heads up, this will be a breaking change to the wasmer cache. The next time we have a release this will be fixed because of #272.

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Mar 27, 2019
@bors
Merge #294
032eb89 
294: add support for symbol maps r=MarkMcCaskey a=MarkMcCaskey

resolves #293 

Co-authored-by: Mark McCaskey <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 27, 2019

Build failed

@MarkMcCaskey
Copy link
Contributor Author

bors retry

bors bot added a commit that referenced this pull request Mar 28, 2019
@bors
Merge #294
43ca9d2 
294: add support for symbol maps r=MarkMcCaskey a=MarkMcCaskey

resolves #293 

Co-authored-by: Mark McCaskey <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 28, 2019

Build failed

@MarkMcCaskey
Copy link
Contributor Author

bors retry

bors bot added a commit that referenced this pull request Mar 28, 2019
@bors
Merge #294
4bbf990 
294: add support for symbol maps r=MarkMcCaskey a=MarkMcCaskey

resolves #293 

Co-authored-by: Mark McCaskey <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 28, 2019

Build succeeded

@bors bors bot merged commit a0e2066 into master Mar 28, 2019
@bors bors bot deleted the feature/add-support-for-symbol-maps branch March 28, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjfish bjfish bjfish left review comments

@xmclark xmclark xmclark approved these changes

Assignees
No one assigned
Labels
🎉 enhancement New feature!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add symbol map support
3 participants
@MarkMcCaskey @bjfish @xmclark