Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache files should be version-dependent #272

Closed
jedisct1 opened this issue Mar 15, 2019 · 3 comments · Fixed by #278
Closed

Cache files should be version-dependent #272

jedisct1 opened this issue Mar 15, 2019 · 3 comments · Fixed by #278
Labels
🎉 enhancement New feature!

Comments

@jedisct1
Copy link

jedisct1 commented Mar 15, 2019 •
edited
Loading

Keys used for cache files only depend on the original wasm file data.

When wasmer is updated or compiled differently, the old cache files keep being silently used forever.

Ideally, a UID generated at compile-time should be used as the BLAKE2B key or salt in order to have a cache directory seamlessly shared by multiple wasmer versions.
@jedisct1 jedisct1 added the 🎉 enhancement New feature! label Mar 15, 2019
@lachlansneff
Copy link
Contributor

So, you're saying that we should version our wasm files somehow, suggesting that it be done by generating a unique salt per wasmer version?

@jedisct1
Copy link
Author

Exactly.

@lachlansneff
Copy link
Contributor

I think this is a good idea and will look into implementing it.

@MarkMcCaskey MarkMcCaskey mentioned this issue Mar 19, 2019
Merged
bors bot added a commit that referenced this issue Mar 19, 2019
@bors @lachlansneff
Merge #278
4a74382 
278: Add versioning to cache r=lachlansneff a=MarkMcCaskey

resolves #272 

Co-authored-by: Mark <[email protected]>
Co-authored-by: Mark McCaskey <[email protected]>
Co-authored-by: Lachlan Sneff <[email protected]>
@bors bors bot closed this as completed in #278 Mar 19, 2019
@MarkMcCaskey MarkMcCaskey mentioned this issue Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎉 enhancement New feature!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add versioning to cache wasmerio/wasmer
2 participants
@jedisct1 @lachlansneff