feat: Build images for forks #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mriyam Tamuli <[email protected]>
Signed-off-by: Mriyam Tamuli <[email protected]>
mugdha-adhav
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
This seems like a good starting point. In future we might want to fine tune conditions like when the images are pushed from the base repository (like only pushing on master branch).
I haven't personally tested the changes, leaving it up to the author to verify the push events are working as expected.
|
CI changes are hard to test without being merged, especially with GitHub actions that only allow workflows to get registered on the default branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100
This PR adds two workflows(One of them is just an updated version of an existing workflow)
.github/workflows/images-build-and-push.yaml- Will build and push images for tags and branches. In case of the main repository, will push to Docker Hub. In case of forks, will push to GitHub Container Registry -ghcr.io/<username>/csi-driver-imagemaking it easier for contributors to test..github/workflows/images-cleanup.yaml- Runs daily cleanup for the forks only. Will only keeplatestor any semver tagged images.