Automated image build and push not working on tags

[mugdha-adhav]

Whenever we create a new tag/release in GitHub, we expect that the image should be pushed for that tag in docker container registry (that's what we support currently).

Yesterday we merged this PR, and this action ran for image build and push on the default (master) branch.

But when we cut a tag v0.8.2 for that change, another action should have been triggered which built and pushed the image with that tag.

[mbtamuli]

Hey 👋🏼 , since I added the workflow for pushing the images, I would like to chime in here.

• I have another workflow with the same conditions and does work correctly on release. I'll try to figure out if something is missing; if I don't find anything, we'll need more debug information - Enabling debug logging.
• I have already started work on a branch https://github.com/mbtamuli/csi-driver-image/tree/feat/images-for-forks related to Well defined developer workflow #96. That workflow is well tested(if you're interested you can take a look at the latest actions runs in that repo).

Any suggestions on which approach to take? @warm-metal/csi-maintainers

1. Fix existing workflow separately.
2. Follow through with the necessities of Well defined developer workflow #96 and get that merged.

[mbtamuli]

Looks like the mentions for team doesn't work for anyone outside the team. (Since 2014 apparently). Please tag the team @mugdha-adhav ?

[mugdha-adhav]

Any suggestions on which approach to take? @warm-metal/csi-maintainers

1. Fix existing workflow separately.
2. Follow through with the necessities of Well defined developer workflow #96 and get that merged.

[mbtamuli]

The way you quoted my reply, it escaped the tagging of the maintainers.

@mugdha-adhav Anyways, maybe you can answer. Any advice on which approach to take?

[mugdha-adhav]

The way you quoted my reply, it escaped the tagging of the maintainers.

Ohh.. I wasn't aware (or didn't give a thorough thought) that the quoted reply would not notify the maintainers. I have updated the comment now.

@mugdha-adhav Anyways, maybe you can answer. Any advice on which approach to take?

I suppose you already have a PR ready for approach 2. JFYI, I have approved the PR.

[mugdha-adhav]

@mbtamuli in the last build that ran on the master branch of this repository after merging #108, it did the following -

1. Skipped login for dockerHub
2. Logged into github container registry
3. Pushed the image to ghcr with tag latest (ghcr.io/warm-metal/csi-driver-image:latest)

Is this the expected behaviour?

[mbtamuli]

@mugdha-adhav No that is not the expected behaviour. Can you re-run the job, this particular one - https://github.com/warm-metal/csi-driver-image/actions/runs/7513491548/job/20455310515, with debug logs - https://docs.github.com/en/actions/managing-workflow-runs/re-running-workflows-and-jobs#re-running-a-specific-job-in-a-workflow?

[mbtamuli]

@mugdha-adhav Thanks for running the debug build. I see an error that I made. The name here is incorrect - warmmetal/csi-driver-image. I'll raise another PR to fix it.

Before I raise the next PR, can you verify if the behaviour of build and push for tags is working as expected? For now it will try to push to ghcr.io, but that'll be fixed in the PR to push to Docker Hub instead.

[mugdha-adhav]

Before I raise the next PR, can you verify if the behaviour of build and push for tags is working as expected?

Tested by creating a temporary tag v1.0.2 (which is already deleted), and here's the workflow that ran on tag creation event as expected 👍🏼

[mbtamuli]

@mugdha-adhav This should give the expected behaviour - #113

[mbtamuli]

@mugdha-adhav As you can see, the workflow is working fine now - https://github.com/warm-metal/csi-driver-image/actions/runs/7514429735/job/20457294891.