Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the PMI URL to directly contain the PMM #37

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Conversation

domenic
Copy link
Collaborator

@domenic domenic commented Aug 12, 2019

Closes #10. In particular, this switches from a HEAD request to a GET request, so that we can inspect the entire body if the Link header is not present.

@rsolomakhin to review.

Closes #10. In particular, this switches from a HEAD request to a GET request, so that we can inspect the entire body if the `Link` header is not present.
@rsolomakhin
Copy link
Collaborator

It's a bit hard to follow the respec formatting. Just to double-check: the spec now issues a GET request and looks for Link first. If Link is found, GET that, otherwise return the contents of the first GET. Is my understanding correct?

@domenic
Copy link
Collaborator Author

domenic commented Aug 12, 2019

Yeah, that's it exactly. The body of the response gets thrown away if any Link is successfully found. I also threw in the ability to terminate the GET if you find such a Link.

Note that unparseable Link values will, in this spec, fall back to trying the body.

@rsolomakhin
Copy link
Collaborator

Note that unparseable Link values will, in this spec, fall back to trying the body.

Nice touch!

@domenic domenic merged commit 3967f4a into master Aug 13, 2019
@domenic domenic deleted the retry-with-get branch August 13, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reconsider extra level of indirection for retrieving a manifest?
2 participants