-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reconsider extra level of indirection for retrieving a manifest? #10
Comments
Thanks for the review! There's actually a another disadvantage to (2) besides being less human readable and more error prone, which is that: it requires the existence of a manifest file. A manifest is a useful tool, but we don't require it. I think there are other issues, but that's the main one. |
I guess not requiring a manifest is another interesting question -- should people really be using new payment methods on the Web without giving any information about how to use them? |
Hey @zkoch we're still a bit perplexed about how you can practically use a custom payment method without saying anything about how it works. I'm also keen to clarify your comment about 'more error prone' - can you confirm my understanding that it is exactly as error prone as any mechanism that requires specifying a full URL of a resource, eg a link from one website to another? |
I agree that discovering and accessing the URL to the Payment Method Manifest via a if a I'm new to this discussion, so forgive my ignorance. are there alternatives that have been proposed elsewhere or in other TAG reviews? |
@cyberphone proposed an excellent solution in rsolomakhin/rsolomakhin.github.io#28:
I think this is a great idea. We should add this to the spec and ship it in Chrome :-D |
Do we think it's a good idea to issue two requests, one HEAD then one GET? Or would it be better to just issue a single GET, and either ignore the body or use it, depending on the headers? |
A single GET makes more sense from the standpoint of architecture. The implementation (not the spec) should also have a fallback to HEAD if the GET fails for those payment handlers that explicitly wait for a HEAD request. We should measure how often the fallback succeed when the initial GET failed. When that number is close to zero, the implementation can remove the HEAD fallback. |
Closes #10. In particular, this switches from a HEAD request to a GET request, so that we can inspect the entire body if the `Link` header is not present.
Closes #10. In particular, this switches from a HEAD request to a GET request, so that we can inspect the entire body if the `Link` header is not present.
Closes #10. In particular, this switches from a HEAD request to a GET request, so that we can inspect the entire body if the `Link` header is not present.
This issue came up in the TAG during discussion of the TAG review in w3ctag/design-reviews#162.
One of the things that bothered a number of us about the specification was that the process for retrieving a manifest from a payment method identifier was to look for a
Link
response header withrel="payment-method-manifest"
from aGET
orHEAD
response on the payment method identifier URL. This seemed bad for two reasons:In w3ctag/design-reviews#162 (comment) @triblondon enumerated four possibilities (including the spec's current behavior):
Within the TAG, there seemed to be the most support for (and no objection to) (2). However, we're certainly missing some of the context that the working group has, so we wouldn't insist on such a change (certainly not at this stage).
That said, we'd be interested in understanding more about the process that led the working group to make the choice it currently did, and whether perhaps there's another option that meets everybody's requirements.
The text was updated successfully, but these errors were encountered: