-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review feed example #565
Comments
For issue #565, modified: examples/feed/feed.html to reword the note that preceeds the intro. The new note wording describes the current implementation as proposed. Task Force review is post poned to next release.
Hi, I'm trying to apply this example and noticed two problems with it:
I would like to see a good example of how to document keyboard controls in an unobtrusive way so that people who rely on them can find them but it's not too "in your face" for others. This is something I've struggled with in other places. It's probably not the WG's task to come up with good accessible design though, but just to explain the technical bits. :-) |
https://w3c.github.io/aria-practices/#wai-aria-roles-states-and-properties-9 says
However, the example does not use |
With thanks to @ianthedev for the original report, here’s a aummary of a related issue: What should happen when @mcking65 what are your thoughts on this? Proposed changes:
|
(moved this comment to a new issue: #1282 ) |
I too have found the current solutions for providing such help text to be lacking. What would be the appropriate channel for getting this kind of thing addressed? Is this a use case that could potentially be addressed by tying into semantics exposed through the Personalization Help and Support module, specifically, helptype, explain, or moreinfo? Theoretically, screen readers could provide affordances for users to have these cues presented to them, right? For instance, users could configure their AT to present the help text by default, based on how they had their software configured, or in response to a key command. Is that part of what was intended to be addressed by the work on Personalization Semantics by the Accessible Platform Architectures Working Group? If so, are they coordinating with screen reader companies to actually implement this kind of functionality? |
Hi there, in the feed example, there is a dropdown to "Select article loading delay". However, because it comes after the feed, it isn't intuitively keyboard accessible (it can be accessed via Thanks for your efforts! |
Hi there, this is my feedback: |
I think each button on the feed should have a unique name. Currently they all have the same name. I suggest each button refer to the title of the tile with either a aria-labelledby. With an id on the button also so it says the title of the tile followed by the title of the button. |
The semantics of the example could also be improved. The articles are marked up using
Let's eat our own dog-food and change this markup to use an Like @stafyniaksacha, I wish we were allowed to use aria-setsize just once on the parent element; alas the current standards for aria-setsize don't allow that. I am writing this on a Mac and it seems voiceover still does not support |
Hi... Has anyone tested this example on a mobile device, though? |
Just echoing what another said. Using the "aria-posinset" and "aria-setsize" attributes on an element with the "role" attribute of "article" produces invalid HTML. |
@jbirdgrant2 wrote:
The HTML is valid. See the spec for role article. |
Thanks. The W3C HTML Validator reports those attributes as errors. Perhaps the validator needs to be updated. |
I'm also interested in recommendations for documenting the keyboard controls of a feed to the user. Also, the mdn web docs mention having controls to navigate in and out of nested feeds (e.g., comments inside of a social media post). It would be nice if the official example also contained a nested feed and some info for the recommended keyboard shortcuts to use for navigating between them. |
Some observations... ProcedureWith JAWS 2024 with verbosity levels high and Announce Live Regions on:
Issue:
|
First, even though the feed role is part of the ARIA specification, unfortunately that does not mean that it has assistive technology support. It is this kind of problem that thearia-at community group and project is striving to prevent. For new ARIA features going forward, it is the goal of the ARIA-AT community group to help define expected assistive technology expectations, ensure the expectations are implementable by assistive technologies, and validate that the ARIA feature design provides users with effective solutions to the problems they are targeting. The feed pattern is not yet on the ARIA-AT schedule. We are not moving as fast as originally planned. I believe the obstacles that were blocking greater momentum are nearly behind us and that we will have a more robust schedule by June 30. It seems that interest in the feed pattern is growing and that there could be good reasons for working to include it in the 2024 schedule. With respect to specific expectations, I anticipate something like the following:
|
@mcking65 , any idea of what is the expected behavior when a screen reader user navigates by bringing up the dialog box of elements, whether links, buttons, or headings? Currently, with this mode of navigation, it's not evident that those elements are part of a feed. The user may think there are only 10 headings when infact going to the 6th heading would cause 10 more to be loaded. |
Having reviewed the JavaScript code in this example, I think it's a bit disingenuous. Pressing "Ctrl+End" should "take you to the next focusable element after the feed," but the example satisfies this requirement by hard coding what the "next focusable element after the feed" is (e.g., the I was looking at the code because it seems to be not exactly straightforward to just grab the next and previous "focusable" items outside of the feed itself. In a similar situation, pressing "Ctrl+Home" actually selects the first focusable element in the feed, not the previous focusable element before the feed. I'm interested to learn how to find these elements in a general sense without explicitly defining them. |
Hi! I agree with the others, I would typically fail under 1.3.1 Info and Relationships for the bookmarks button. They are visually associated to the article but not programmatically. But I could be wrong. @patrickhlauke Hi Patrick, I hope you dont mind me summoning you because you are a pro at figuring out these gray areas. In your opinion, would the bookmark buttons of the Infinite Scrolling Feed Example be a failure of 1.3.1 Info and Relationships? |
The feed example
developed for issue #246 is ready for review.
The text was updated successfully, but these errors were encountered: