-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feed design pattern's example should change aria-busy when there's an error #1282
Comments
@zcorpan are you proposing a change in the actual code for the example? I agree with the principle, but right now there's nothing there that allows for the existence of an error condition, since it's all faked with One thing we could do (and this makes the most sense to me) is update the example to actually |
Yes, I think the |
If there are no objections, I'll make a PR changing the feed example to use |
@smhigley might need a polyfill to use |
I really want to drop support for IE11 😅. But yeah, will use this for now: https://github.com/github/fetch |
Per #1304 seems like we can use |
If there is an error in loading of new sections,
aria-busy="true"
will still be set, leaving the entire feed inaccessible.Although this example doesn't
fetch
new content, a real-world example probably would, which makes it more likely for an error to happen (e.g., the user temporarily loses network access).The code should be resilient to any error, maybe show an error message when an error does happen, and remove the
aria-busy
attribute.The design pattern should also discuss this, I think.
I noticed this while writing a new section for
aria-busy
in #1027.Originally posted by @zcorpan in #565 (comment)
The text was updated successfully, but these errors were encountered: