Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct deprecation date #780

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

evmiguel
Copy link
Contributor

As discussed with @howard-e, this PR changes the migration to compare against the most recent version in the database and deprecate against that version.

@evmiguel evmiguel requested a review from howard-e September 19, 2023 21:28
@howard-e howard-e linked an issue Sep 20, 2023 that may be closed by this pull request
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evmiguel thanks, LGTM!

@howard-e howard-e merged commit ad03f01 into show-all-timeline-versions Sep 20, 2023
@howard-e howard-e deleted the correct-deprecation-dates branch September 20, 2023 22:25
howard-e added a commit that referenced this pull request Sep 21, 2023
…773)

* Show all versions in 'Timeline for All Versions' table

* Update timestamp migrations to use more real world change phase change times (avoid exact time being set for when one phase ends and another begins)

* Update import script to have a 'delayed' time on the report being deprecated

* Add td -> th for first column cell for Version Summary and Timeline related tables

* Match sort order described in #719

* Correct deprecation date (#780)

* Compare most recent test plan version to deprecate against

* Correct deprecation date without using the more recent test plan version since it's being set already

---------

Co-authored-by: Erika Miguel <[email protected]>
howard-e added a commit that referenced this pull request Sep 28, 2023
…abase Implementation to support #648 (#688)

Changes added to primarily support #648, but also #518 and w3c/aria-at#950. This includes functional changes to the Data Management, the Test Queue and the Candidate Review pages. It also includes changes to the database structure, described in #632.

* feature: updates functionality of Data Management page (#713)
* feature: updates functionality of Test Queue page (#715)
* feature: updates functionality of Candidate Review page (#715) 
* feature: include functionality to support the concept of required reports (#722)
* feature: adds Test Plan Report Status dialog (#728)
* enhancement: move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Review page (#730)
* feature: adds Test Plan Version page (#747)
* enhancement: explicitly support ‘DEPRECATED’ phase status for TestPlanVersions (#749)
* feature: adds filter and sorting functionality by columns headers on Data Management page (#750)
* bugfix: update semantic structure of cells with multiple list items on Data Management page (#752)
* enhancement: include GitHub issues on Test Plan Version page (#753)
* bugfix: revision of the required reports conditions for updating to CANDIDATE and RECOMMENDED phases (#764)
* bugfix: removes superfluous header from Test Plan Report Status dialog (#766)
* bugfix: update and revise sorts, headings and descriptions of elements on Test Plan Version page (#767)
* bugfix: account for several other update phase scenarios that could prevent the update from happening if there is an older TestPlanVersion that exists with results (#771)
* bugfix: update headings and revise deprecated dates shown on Test Plan Version page (#773)
* enhancement: allow updating of GitHub issues being presented in the app to be more easily understood (#775)
* bugfix: correct deprecatedAt date to be relative to when the ‘next’ TestPlanVersion was added (#780)
* enhancement: update the text shown when deprecation occurs during a phase on Test Plan Version page (#781)
* bugfix: fix inverted sort descriptions and pin sort of of Test Plan name columns on Data Management page (#790)

---------

Co-authored-by: Erika Miguel <[email protected]>
Co-authored-by: Paul Clue <[email protected]>
Co-authored-by: alflennik <[email protected]>
Co-authored-by: Stalgia Grigg <[email protected]>
Co-authored-by: Howard Edwards <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test plan version history shows incorrect deprecation dates
2 participants