Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Timeline for All Versions table on Test Plan Versions Page #773

Merged
merged 6 commits into from
Sep 21, 2023
Merged

Update Timeline for All Versions table on Test Plan Versions Page #773

merged 6 commits into from
Sep 21, 2023

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Sep 14, 2023 •
edited
Loading

Address:

The timeline for all versions should show all events from all versions. The timeline for each individual version should show all events for that specific version. Thus, the number of rows in timeline for all versions should be the sum of all rows from the other timeline tables.

It would make the tables more screen reader friendly if we used th instead of td in the version column of the version summary and the date column of the timeline tables.

@howard-e howard-e linked an issue Sep 14, 2023 that may be closed by this pull request
Add Test Plan Versions page that provides the complete version history for a test plan (P1) #719
Closed
This was referenced Sep 14, 2023
Closed
Merged
alflennik
alflennik approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, it makes sense to just make sure the timeline occurs in the proper order, it's a clean solution. I appreciate that most of the complexity is contained to the migrations. I tested it out and saw the fix in action. All the test plan version pages seem to be working properly.

@evmiguel
Correct deprecation date (#780)
ad03f01 
* Compare most recent test plan version to deprecate against

* Correct deprecation date without using the more recent test plan version since it's being set already
@howard-e howard-e merged commit 87abb14 into update-database-impl Sep 21, 2023
@howard-e howard-e deleted the show-all-timeline-versions branch September 21, 2023 20:06
howard-e added a commit that referenced this pull request Sep 28, 2023
@howard-e @evmiguel
@Paul-Clue @alflennik @stalgiag
Update Data Management, Test Queue and Candidate Review Pages and Dat…
14563b0 
…abase Implementation to support #648 (#688)

Changes added to primarily support #648, but also #518 and w3c/aria-at#950. This includes functional changes to the Data Management, the Test Queue and the Candidate Review pages. It also includes changes to the database structure, described in #632.

* feature: updates functionality of Data Management page (#713)
* feature: updates functionality of Test Queue page (#715)
* feature: updates functionality of Candidate Review page (#715) 
* feature: include functionality to support the concept of required reports (#722)
* feature: adds Test Plan Report Status dialog (#728)
* enhancement: move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Review page (#730)
* feature: adds Test Plan Version page (#747)
* enhancement: explicitly support ‘DEPRECATED’ phase status for TestPlanVersions (#749)
* feature: adds filter and sorting functionality by columns headers on Data Management page (#750)
* bugfix: update semantic structure of cells with multiple list items on Data Management page (#752)
* enhancement: include GitHub issues on Test Plan Version page (#753)
* bugfix: revision of the required reports conditions for updating to CANDIDATE and RECOMMENDED phases (#764)
* bugfix: removes superfluous header from Test Plan Report Status dialog (#766)
* bugfix: update and revise sorts, headings and descriptions of elements on Test Plan Version page (#767)
* bugfix: account for several other update phase scenarios that could prevent the update from happening if there is an older TestPlanVersion that exists with results (#771)
* bugfix: update headings and revise deprecated dates shown on Test Plan Version page (#773)
* enhancement: allow updating of GitHub issues being presented in the app to be more easily understood (#775)
* bugfix: correct deprecatedAt date to be relative to when the ‘next’ TestPlanVersion was added (#780)
* enhancement: update the text shown when deprecation occurs during a phase on Test Plan Version page (#781)
* bugfix: fix inverted sort descriptions and pin sort of of Test Plan name columns on Data Management page (#790)

---------

Co-authored-by: Erika Miguel <[email protected]>
Co-authored-by: Paul Clue <[email protected]>
Co-authored-by: alflennik <[email protected]>
Co-authored-by: Stalgia Grigg <[email protected]>
Co-authored-by: Howard Edwards <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alflennik alflennik alflennik approved these changes

@stalgiag stalgiag Awaiting requested review from stalgiag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Test Plan Versions page that provides the complete version history for a test plan (P1)
3 participants
@howard-e @alflennik @evmiguel