Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests which have been re-ran to update results to avoid conflicts between testers still incorrectly display conflicting results #685

Merged
merged 10 commits into from
Jul 19, 2023

Conversation

Paul-Clue
Copy link
Collaborator

On the Test Queue page (/test-queue), there are test plans showing conflicts even though multiple testers have the same test results. The problem is that, somehow, some tests that end up with an unexpected behavior ID of "EXCESSIVELY VERBOSE" end up with otherUnexpectedBehaviorText in unexpectedBehavior array. The otherUnexpectedBehaviorText should not be there.

This PR removes the otherUnexpectedBehaviorText from unexpectedBehavior arrays that are already in the database and it prevents the problem from occurring in future test plans.

@Paul-Clue Paul-Clue requested review from evmiguel and howard-e June 8, 2023 16:57
@ccanash ccanash requested review from alflennik and removed request for evmiguel June 14, 2023 15:53
Copy link
Contributor

@howard-e howard-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Paul-Clue, it looks good!

I've only left a comment about the info being logged.

const conflicts = await conflictsResolver(
testPlanReport,
null,
{ atLoader, browserLoader }
Copy link
Contributor

@howard-e howard-e Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought, and not suggesting as something to act on as it's outside the scope of this PR.

Right now, the GQL context could be { user, atLoader, browserLoader } with the change in #623. Now that I've seen its usage a bit more, it seems atLoader and browserLoader being present is a must in most queries.

So I'd think that when context is null in the resolvers it's called, it may be preferred if it simply defaults to { atLoader, browserLoader }. I'm unsure if sure if there's any implications to that though, and also acknowledge that it would a considerable effort in determining that. But creating the objects here to solely retrieve the conflict results here felt out of place.

@Paul-Clue Paul-Clue merged commit 8169d43 into main Jul 19, 2023
@Paul-Clue Paul-Clue deleted the conflicting-re-ran-tests branch July 19, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application incorrectly marking results as conflicts
2 participants