completions steps were disconnected from algo, and 'append' instruction was phrased as a 'join' #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on was phrased as a 'join' closes #142
cookiecrook
commented
Feb 7, 2023
| @@ -363,7 +363,7 @@ <h4>Computation steps</h4> | |||
| <ol> | |||
| <li id="comp_labelledby_set_current" name="step2B.ii.a">Set the <code>current node</code> to the node referenced by the IDREF.</li> | |||
| <li id="comp_labelledby_recursion" name="step2B.ii.b"><em>LabelledBy Recursion:</em> Compute the text alternative of the <code>current node</code> beginning with the overall <a href="#comp_computation">Computation</a> step. Set the <code>result</code> to that text alternative.</li> | |||
| <li id="comp_labelledby_append" name="step2B.ii.c">Append the <code>result</code>, with a space, to the <code>accumulated text</code>.</li> | |||
| <li id="comp_labelledby_append" name="step2B.ii.c">Append a space character and the <code>result</code> to the <code>accumulated text</code>.</li> | |||
There was a problem hiding this comment.
Justification for including this change: while adding id="comp_append" below, I noticed these "append" steps were actually phrased as "joins" ("append the result with a space" is += "result " not += " result") so I rephrased for accuracy. If the editors prefer, I can include this separately.
There was a problem hiding this comment.
I think it's fine to leave in here, it's essentially equivalent to "fixing a typo" IMO
| @@ -464,11 +464,11 @@ <h4>Computation steps</h4> | |||
| <p>Tooltip attributes are used only if nothing else, including subtree content, has provided results. </p> | |||
| </details></div> | |||
| </li> | |||
| <li id="comp_append">Append a space character and the <code>result</code> of each step above to the <code>total accumulated text</code>.</li> | |||
There was a problem hiding this comment.
Still editorial IMO.
MelSumner
approved these changes
Feb 13, 2023
| @@ -363,7 +363,7 @@ <h4>Computation steps</h4> | |||
| <ol> | |||
| <li id="comp_labelledby_set_current" name="step2B.ii.a">Set the <code>current node</code> to the node referenced by the IDREF.</li> | |||
| <li id="comp_labelledby_recursion" name="step2B.ii.b"><em>LabelledBy Recursion:</em> Compute the text alternative of the <code>current node</code> beginning with the overall <a href="#comp_computation">Computation</a> step. Set the <code>result</code> to that text alternative.</li> | |||
| <li id="comp_labelledby_append" name="step2B.ii.c">Append the <code>result</code>, with a space, to the <code>accumulated text</code>.</li> | |||
| <li id="comp_labelledby_append" name="step2B.ii.c">Append a space character and the <code>result</code> to the <code>accumulated text</code>.</li> | |||
There was a problem hiding this comment.
I think it's fine to leave in here, it's essentially equivalent to "fixing a typo" IMO
|
@jnurthen @spectranaut merge? |
accdc
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #142
Preview | Diff