-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permalinks in computations should NOT use specific numbering in the link (because the numbering will change) #139
Comments
Thoughts from 8/19 Deep Dive - folks please edit this. Going off the Computation steps in the ED: The first string would be human understandable text names that would be rendered at the beginning of every major step, and any important sub-step that we agree with worth linking. The id value is the proposed unique ID for permalinks; prefixed here with "comp_"
|
Open questions... (feel free to edit this comment too)
|
Should the text above be "Step 3"? Update: Filed as #142 |
I have completed a first pass proposal in @jnurthen's comment above. @jnurthen, @joanmarie, @accdc, and @aleventhal please review. |
This seems logical to me. Do others have any opinions? |
Also we can change the legacy |
Closes #139 Named IDs and visible step names intended to promote understandability. Retained legacy step IDs (2B or not ii.b) as name attr values so to not break external links.
The AccName computation permalinks to specific steps are unique to their current position in the list, rather than unique to the content of the list item. For example
step2B.ii.c
:I believe this should be changed, as we reorder or add items from time-to-time. Keeping these numbered permalinks would either break permalinking, or would result in confusing legacy hashes that don't match the number.
Instead, they should use a unique, somewhat human readable ID ref, such as:
Then the link wouldn't need to change if reordering happened.
The text was updated successfully, but these errors were encountered: