Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#394 adds missing header to POST requests #395

Merged
merged 1 commit into from
Oct 6, 2020
Merged

#394 adds missing header to POST requests #395

merged 1 commit into from
Oct 6, 2020

Conversation

spencerkordecki
Copy link
Collaborator

Description

Fixes #394 by adding the header of "Content-Type: application/x-www-form-urlencoded" which was automatically added by the usage of URLSearchParams(), but when that was removed in #373, the header was missing and caused an error with POST requests.

Related Issues

Fixes #394 , consequence of #373

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #395 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   95.70%   95.74%   +0.03%     
==========================================
  Files          23       23              
  Lines         233      235       +2     
  Branches       21       21              
==========================================
+ Hits          223      225       +2     
  Misses         10       10              
Impacted Files Coverage Δ
src/util.js 69.56% <100.00%> (+2.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e7f4b...00c60d1. Read the comment docs.

@ddymko ddymko merged commit 61cad66 into master Oct 6, 2020
@ddymko ddymko added this to the v1.0.1 milestone Oct 6, 2020
@spencerkordecki spencerkordecki deleted the issue-394 branch October 30, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Version 1.0.0 can't create a new server
2 participants