Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PolyFill to support IOS #373

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Conversation

MinisculeGirraffe
Copy link

Description

IOS does not support URLSearchParams(). Consequently any POST requests ran from an IOS device with this library fail.

Related Issues

Fixes Issue 372

Checklist:

  • [X ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [ X] Have you linted your code locally prior to submission?
  • [ X] Have you successfully ran tests with your changes locally?

@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #373 into master will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
- Coverage   95.72%   95.67%   -0.06%     
==========================================
  Files          23       23              
  Lines         234      231       -3     
  Branches       21       21              
==========================================
- Hits          224      221       -3     
  Misses         10       10              
Impacted Files Coverage Δ
src/util.js 66.66% <66.66%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff0977d...51eacda. Read the comment docs.

@ddymko ddymko merged commit 825a2dc into vultr:master Aug 31, 2020
@ddymko
Copy link
Contributor

ddymko commented Aug 31, 2020

Closes #372

@ddymko ddymko added this to the v0.5.0 milestone Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants